From: Jani Nikula <jani.nikula@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/mst: Set intel_dp_set_m_n() for MST slaves
Date: Tue, 11 Feb 2020 18:12:26 +0200 [thread overview]
Message-ID: <87a75pyufp.fsf@intel.com> (raw)
In-Reply-To: <871rr2w4n5.fsf@intel.com>
On Mon, 10 Feb 2020, Jani Nikula <jani.nikula@intel.com> wrote:
> On Mon, 10 Feb 2020, José Roberto de Souza <jose.souza@intel.com> wrote:
>> Commit 1c9d2eb24153 ("drm/i915: move intel_dp_set_m_n() to encoder for
>> DDI platforms") moved the intel_dp_set_m_n() from hsw_crtc_enable()
>> to intel_ddi_pre_enable_dp() but it missed add it to
>> intel_mst_pre_enable_dp() causing MST slaves to not work.
>>
>> Fixes: 1c9d2eb24153 ("drm/i915: move intel_dp_set_m_n() to encoder for DDI platforms")
>> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>
> Damn it, this is the second DP MST thing I missed in the same
> series. *facepalm*. The first goof-up was fixed in commit 274959622017
> ("drm/i915/mst: fix pipe and vblank enable"). We really need more MST in
> CI.
Actually, wondering if the intel_dp_set_m_n() call in
intel_ddi_pre_enable_dp() now needs to be wrapped in
if (!intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST))
Similar to intel_ddi_set_dp_msa().
BR,
Jani.
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
>> index 9cd59141953d..d7bfa7c350e9 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
>> @@ -480,6 +480,8 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
>> intel_ddi_enable_pipe_clock(pipe_config);
>>
>> intel_ddi_set_dp_msa(pipe_config, conn_state);
>> +
>> + intel_dp_set_m_n(pipe_config, M1_N1);
>> }
>>
>> static void intel_mst_enable_dp(struct intel_encoder *encoder,
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-11 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 18:40 [Intel-gfx] [PATCH] drm/i915/mst: Set intel_dp_set_m_n() for MST slaves José Roberto de Souza
2020-02-10 20:47 ` Jani Nikula
2020-02-11 16:12 ` Jani Nikula [this message]
2020-02-11 18:11 ` Souza, Jose
2020-02-10 20:55 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2020-02-10 23:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mst: Set intel_dp_set_m_n() for MST slaves (rev2) Patchwork
2020-02-12 9:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a75pyufp.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).