From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/6] drm/i915: Reject bogus modes with fixed mode panels
Date: Fri, 24 Sep 2021 13:48:51 +0300 [thread overview]
Message-ID: <87wnn69rl8.fsf@intel.com> (raw)
In-Reply-To: <20210923200109.4459-1-ville.syrjala@linux.intel.com>
On Thu, 23 Sep 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Let's start to reject user modes whose refresh rate is
> nowhere near the actual fixed mode refresh rate we're
> going to use. ATM we're just flat out lying to the user.
I eyeballed through this quickly, mostly seems reasonable, I'll try to
do detailed review later.
One question though. I think we have bug reports [1][2] about panels
that support very high refresh rates, but report a lower refresh rate
mode as the preferred mode. It's perhaps a safe default from a power
usage standpoint. Does this series make using those modes harder or
impossible?
BR,
Jani.
[1] https://gitlab.freedesktop.org/drm/intel/-/issues/2939
[2] https://gitlab.freedesktop.org/drm/intel/-/issues/3969
>
> We'll also pimp the connector's mode list validation
> a bit.
>
> Ville Syrjälä (6):
> drm/i915: Extract intel_panel_mode_valid()
> drm/i915: Use intel_panel_mode_valid() for DSI/LVDS/DVO
> drm/i915: Reject modes that don't match fixed_mode vrefresh
> drm/i915: Introduce intel_panel_compute_config()
> drm/i915: Reject user modes that don't match fixed mode's refresh rate
> drm/i915: Drop pointless fixed_mode checks from dsi code
>
> drivers/gpu/drm/i915/display/icl_dsi.c | 7 ++--
> drivers/gpu/drm/i915/display/intel_dp.c | 13 ++++---
> drivers/gpu/drm/i915/display/intel_dsi.c | 16 ++++-----
> drivers/gpu/drm/i915/display/intel_dvo.c | 24 ++++++++-----
> drivers/gpu/drm/i915/display/intel_lvds.c | 15 ++++----
> drivers/gpu/drm/i915/display/intel_panel.c | 41 ++++++++++++++++++++--
> drivers/gpu/drm/i915/display/intel_panel.h | 5 +++
> drivers/gpu/drm/i915/display/intel_sdvo.c | 21 ++++++-----
> drivers/gpu/drm/i915/display/vlv_dsi.c | 39 +++++++++-----------
> 9 files changed, 116 insertions(+), 65 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-09-24 10:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 20:01 [Intel-gfx] [PATCH 0/6] drm/i915: Reject bogus modes with fixed mode panels Ville Syrjala
2021-09-23 20:01 ` [Intel-gfx] [PATCH 1/6] drm/i915: Extract intel_panel_mode_valid() Ville Syrjala
2021-09-23 20:01 ` [Intel-gfx] [PATCH 2/6] drm/i915: Use intel_panel_mode_valid() for DSI/LVDS/DVO Ville Syrjala
2021-09-23 20:01 ` [Intel-gfx] [PATCH 3/6] drm/i915: Reject modes that don't match fixed_mode vrefresh Ville Syrjala
2021-09-23 20:01 ` [Intel-gfx] [PATCH 4/6] drm/i915: Introduce intel_panel_compute_config() Ville Syrjala
2021-09-24 12:41 ` Ville Syrjälä
2021-09-27 18:52 ` [Intel-gfx] [PATCH v2 " Ville Syrjala
2021-09-23 20:01 ` [Intel-gfx] [PATCH 5/6] drm/i915: Reject user modes that don't match fixed mode's refresh rate Ville Syrjala
2021-09-27 18:52 ` [Intel-gfx] [PATCH v2 " Ville Syrjala
2021-09-29 18:45 ` [Intel-gfx] [PATCH v3 " Ville Syrjala
2021-09-23 20:01 ` [Intel-gfx] [PATCH 6/6] drm/i915: Drop pointless fixed_mode checks from dsi code Ville Syrjala
2021-09-23 22:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject bogus modes with fixed mode panels Patchwork
2021-09-24 3:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-24 10:48 ` Jani Nikula [this message]
2021-09-24 11:24 ` [Intel-gfx] [PATCH 0/6] " Ville Syrjälä
2021-09-27 21:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject bogus modes with fixed mode panels (rev3) Patchwork
2021-09-28 2:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-29 5:47 ` [Intel-gfx] [PATCH 0/6] drm/i915: Reject bogus modes with fixed mode panels Jani Nikula
2021-09-29 19:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject bogus modes with fixed mode panels (rev4) Patchwork
2021-09-29 22:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnn69rl8.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).