intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Stéphane Marchesin" <marcheu@chromium.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Ajdust down threshold in intel_pm.
Date: Wed, 15 Aug 2012 14:46:10 -0700	[thread overview]
Message-ID: <CADMs+9Z6oYcZHSa0iFUQaDUeBYyRwH98yaWT6ouW540N8ajx9Q@mail.gmail.com> (raw)
In-Reply-To: <20120716195039.GD5023@phenom.ffwll.local>


[-- Attachment #1.1: Type: text/plain, Size: 1850 bytes --]

On Mon, Jul 16, 2012 at 12:50 PM, Daniel Vetter <daniel@ffwll.ch> wrote:

> On Wed, Jul 04, 2012 at 09:52:11AM +0200, Daniel Vetter wrote:
> > On Tue, Jul 03, 2012 at 02:16:42PM -0700, Stéphane Marchesin wrote:
> > > The up and down thresholds are very asymetric, so it is possible
> > > to have a case where a spike of rendering increases the GPU clock to
> > > the max (because the up threshold is low) and then a simple blinking
> > > cursor is enough to keep the clock at the maximum speed forever
> > > (because the down threshold is high).
> > >
> > > Lowering the down threshold allows the GPU clock to go back down even
> > > when there is a blinking cursor on the screen.
> > >
> > > Signed-off-by: Stéphane Marchesin <marcheu@chromium.org>
> >
> > I've just merged Eugeni's hsw rc6 patches - those contain newly tuning
> > variables. Can you maybe try out whether these would have the same
> effect?
> > I'd prefer to simple enable these, presuming that the hw guys we've got
> > them from did some decent tuning ...
>
> Ping.
>
> 3.6 merge window is approach fast and I think I'd be good to get this in
> ... Or something similar, based on the hsw ratio between downclock and
> upclock limit, but with the slightly bigger thresholds used by ivb/snb for
> upclocks maybe?
>

So now that the dust settled, and that we better understand what's going
on, I am sure that those values are not adequate for us (neither the
default SNB/IVB, nor the Haswell ones).

For the record, here is what we set differently for Chrome OS to solve our
issues (we didn't see a performance regression, but we do get a major power
consumption reduction for lighter GPU loads like playing a video and that
blinking cursor):

GEN6_RP_DOWN_TIMEOUT 10000
GEN6_RP_UP_THRESHOLD 0x4000
GEN6_RP_DOWN_THRESHOLD 0x4000

Stéphane

[-- Attachment #1.2: Type: text/html, Size: 2471 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2012-08-15 21:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 21:16 [PATCH] drm/i915: Ajdust down threshold in intel_pm Stéphane Marchesin
2012-07-04  7:52 ` Daniel Vetter
2012-07-16 19:50   ` Daniel Vetter
2012-08-15 21:46     ` Stéphane Marchesin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADMs+9Z6oYcZHSa0iFUQaDUeBYyRwH98yaWT6ouW540N8ajx9Q@mail.gmail.com \
    --to=marcheu@chromium.org \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).