From: jim.cromie@gmail.com
To: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>,
daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, ppaalanen@gmail.com,
Sean Paul <seanpaul@chromium.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [Intel-gfx] [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers
Date: Wed, 28 Jul 2021 10:39:48 -0400 [thread overview]
Message-ID: <CAJfuBxw2uAZozKgG58KvFnQfw8hzcqrzUfN=B0ucYDkU=h40=A@mail.gmail.com> (raw)
In-Reply-To: <20210721175526.22020-4-sean@poorly.run>
On Wed, Jul 21, 2021 at 1:55 PM Sean Paul <sean@poorly.run> wrote:
>
> From: Sean Paul <seanpaul@chromium.org>
>
> Use drm logging helpers to add support for the upcoming tracefs
> implementation.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-4-sean@poorly.run #v5
>
> Changes in v5:
> -Added to the set
> Changes in v6:
> -None
> ---
> drivers/gpu/drm/i915/i915_utils.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index f9e780dee9de..d858c92c6997 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -30,10 +30,9 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
> vaf.va = &args;
>
> if (is_error)
> - dev_printk(level, kdev, "%pV", &vaf);
> + drm_dev_printk(kdev, level, "%pV", &vaf);
> else
> - dev_printk(level, kdev, "[" DRM_NAME ":%ps] %pV",
> - __builtin_return_address(0), &vaf);
> + drm_err(&dev_priv->drm, "%pV", &vaf);
its slightly jarring to see drm_err() in the !is_err branch.
warn or notice seems better.
>
> va_end(args);
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-07-28 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210721175526.22020-1-sean@poorly.run>
2021-07-21 17:55 ` [Intel-gfx] [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers Sean Paul
2021-07-28 14:39 ` jim.cromie [this message]
2021-07-21 17:55 ` [Intel-gfx] [RESEND PATCH v6 09/14] drm/i915: Change infoframe debug checks to specify syslog Sean Paul
2021-07-21 17:55 ` [Intel-gfx] [RESEND PATCH v6 12/14] drm/i915: Use debug category printer for welcome message Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfuBxw2uAZozKgG58KvFnQfw8hzcqrzUfN=B0ucYDkU=h40=A@mail.gmail.com' \
--to=jim.cromie@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ppaalanen@gmail.com \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).