From: Sean Paul <sean@poorly.run>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Sean Paul <seanpaul@chromium.org>
Subject: Re: [Intel-gfx] [PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors
Date: Wed, 20 May 2020 09:11:38 -0400 [thread overview]
Message-ID: <CAMavQKL495j9aVj_0_jnwATW-rmyU5V=coBB-keQ78+1bmREUg@mail.gmail.com> (raw)
In-Reply-To: <20200518164130.GA14897@intel.com>
On Mon, May 18, 2020 at 12:41 PM Ramalingam C <ramalingam.c@intel.com> wrote:
>
> On 2020-05-18 at 10:32:09 -0400, Sean Paul wrote:
> > On Fri, May 15, 2020 at 10:48 AM Ramalingam C <ramalingam.c@intel.com> wrote:
> > >
> > > On 2020-04-29 at 15:54:46 -0400, Sean Paul wrote:
> > > > From: Sean Paul <seanpaul@chromium.org>
> > > >
> > > > Changes in v6:
> > > > -Rebased on -tip
> > > > -Disabled HDCP over MST on GEN12
> > > > -Addressed Lyude's review comments in the QUERY_STREAM_ENCRYPTION_STATUS patch
> > >
> > > Sean,
> > >
> > > What is the test setup you have used?
> > >
> >
> > Hi Ram,
> > Thanks for the feedback. To be completely honest it's really
> > frustrating that I'm just now getting questions and review feedback
> > (which I've been begging for on IRC) on this review that could have
> > been addressed ~5 months ago. It's super disruptive to have to keep
> > switching back to this after a long hiatus and many i915 refactors
> > complicating my rebases.
> Hi Sean,
>
> As a developer I really feel bad for the delay happened in review.
> I couldn't spend required time for understanding MST part hence I
> couldn't review.
>
> Just for this series now I have started preparing myself on these topics,
> hence started reviewing the series.
>
> If you are still interested to work on this, I can commit for regular reviews.
>
Thanks Ram. I'm still incentivized to get this in. Once you have had a
chance to look over the whole series, I'll revise again.
Sean
> Thanks,
> Ram.
> >
> > If no one wants this patchset, that's fine, please just let me know so
> > I don't waste any more time. If Intel is interested, could we please
> > stop the review trickle and lay out exactly what needs to be done to
> > get this landed?
> >
> > Sean
> >
> >
> > > I am afraid our CI dont have the coverage for MST capability yet to provide
> > > the functional status of the code.
> > >
> > > -Ram.
> > > >
> > > > Sean Paul (16):
> > > > drm/i915: Fix sha_text population code
> > > > drm/i915: Clear the repeater bit on HDCP disable
> > > > drm/i915: WARN if HDCP signalling is enabled upon disable
> > > > drm/i915: Intercept Aksv writes in the aux hooks
> > > > drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP
> > > > signalling
> > > > drm/i915: Factor out hdcp->value assignments
> > > > drm/i915: Protect workers against disappearing connectors
> > > > drm/i915: Don't fully disable HDCP on a port if multiple pipes are
> > > > using it
> > > > drm/i915: Support DP MST in enc_to_dig_port() function
> > > > drm/i915: Use ddi_update_pipe in intel_dp_mst
> > > > drm/i915: Factor out HDCP shim functions from dp for use by dp_mst
> > > > drm/i915: Plumb port through hdcp init
> > > > drm/i915: Add connector to hdcp_shim->check_link()
> > > > drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband
> > > > message
> > > > drm/i915: Print HDCP version info for all connectors
> > > > drm/i915: Add HDCP 1.4 support for MST connectors
> > > >
> > > > drivers/gpu/drm/drm_dp_mst_topology.c | 142 ++++
> > > > drivers/gpu/drm/i915/Makefile | 1 +
> > > > drivers/gpu/drm/i915/display/intel_ddi.c | 29 +-
> > > > drivers/gpu/drm/i915/display/intel_ddi.h | 2 +
> > > > .../drm/i915/display/intel_display_debugfs.c | 21 +-
> > > > .../drm/i915/display/intel_display_types.h | 30 +-
> > > > drivers/gpu/drm/i915/display/intel_dp.c | 654 +--------------
> > > > drivers/gpu/drm/i915/display/intel_dp.h | 9 +
> > > > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 743 ++++++++++++++++++
> > > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 19 +
> > > > drivers/gpu/drm/i915/display/intel_hdcp.c | 217 +++--
> > > > drivers/gpu/drm/i915/display/intel_hdcp.h | 2 +-
> > > > drivers/gpu/drm/i915/display/intel_hdmi.c | 25 +-
> > > > .../drm/selftests/test-drm_dp_mst_helper.c | 17 +
> > > > include/drm/drm_dp_helper.h | 3 +
> > > > include/drm/drm_dp_mst_helper.h | 44 ++
> > > > include/drm/drm_hdcp.h | 3 +
> > > > 17 files changed, 1235 insertions(+), 726 deletions(-)
> > > > create mode 100644 drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > > >
> > > > --
> > > > Sean Paul, Software Engineer, Google / Chromium OS
> > > >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-20 13:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 19:54 [Intel-gfx] [PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors Sean Paul
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 01/16] drm/i915: Fix sha_text population code Sean Paul
2020-05-01 2:55 ` Sasha Levin
2020-05-06 14:00 ` Ramalingam C
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 02/16] drm/i915: Clear the repeater bit on HDCP disable Sean Paul
2020-05-01 2:55 ` Sasha Levin
2020-05-06 14:02 ` Ramalingam C
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 03/16] drm/i915: WARN if HDCP signalling is enabled upon disable Sean Paul
2020-05-06 14:18 ` Ramalingam C
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 04/16] drm/i915: Intercept Aksv writes in the aux hooks Sean Paul
2020-05-06 14:13 ` Ramalingam C
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 05/16] drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling Sean Paul
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 06/16] drm/i915: Factor out hdcp->value assignments Sean Paul
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 07/16] drm/i915: Protect workers against disappearing connectors Sean Paul
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 08/16] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it Sean Paul
2020-05-15 12:39 ` Ramalingam C
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 09/16] drm/i915: Support DP MST in enc_to_dig_port() function Sean Paul
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 10/16] drm/i915: Use ddi_update_pipe in intel_dp_mst Sean Paul
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 11/16] drm/i915: Factor out HDCP shim functions from dp for use by dp_mst Sean Paul
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 12/16] drm/i915: Plumb port through hdcp init Sean Paul
2020-04-29 19:54 ` [Intel-gfx] [PATCH v6 13/16] drm/i915: Add connector to hdcp_shim->check_link() Sean Paul
2020-04-29 19:55 ` [Intel-gfx] [PATCH v6 14/16] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message Sean Paul
2020-04-29 19:55 ` [Intel-gfx] [PATCH v6 15/16] drm/i915: Print HDCP version info for all connectors Sean Paul
2020-04-29 19:55 ` [Intel-gfx] [PATCH v6 16/16] drm/i915: Add HDCP 1.4 support for MST connectors Sean Paul
2020-05-15 14:42 ` Ramalingam C
2020-06-18 18:20 ` Sean Paul
2020-04-29 20:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for HDCP 1.4 over MST connectors (rev6) Patchwork
2020-04-29 21:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-30 5:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-05-15 14:48 ` [Intel-gfx] [PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors Ramalingam C
2020-05-18 14:32 ` Sean Paul
2020-05-18 16:41 ` Ramalingam C
2020-05-20 13:11 ` Sean Paul [this message]
2020-05-26 10:38 ` Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMavQKL495j9aVj_0_jnwATW-rmyU5V=coBB-keQ78+1bmREUg@mail.gmail.com' \
--to=sean@poorly.run \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).