On Tue,  7 Jun 2011 15:54:39 -0700, Kenneth Graunke <kenneth@whitecape.org> wrote:
> According to BSpec volume 1c.4 section 3.2.9, Display (Plane) Select is
> now at bits 21:19 instead of 21:20.
> 
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>

I will note that the docs have an obvious bug -- 21:8 are 'reserved' on
IVB while 21:19 are 'Display (Plane) Select'. I trust you've actually
tried this on hardware and noticed that it works better now?


> +
> +	case 7:
> +		OUT_RING(MI_DISPLAY_FLIP | (intel_crtc->plane << 19));
> +		OUT_RING(fb->pitch | obj->tiling_mode);
> +		OUT_RING(obj->gtt_offset);
> +
> +		pf = I915_READ(PF_CTL(pipe)) & PF_ENABLE;
> +		pipesrc = I915_READ(PIPESRC(pipe)) & 0x0fff0fff;
> +		OUT_RING(pf | pipesrc);

What's this last DWORD supposed to be for? The IVB spec says length
should be '1' and there should be only 3 DWORDS in this command.

-- 
keith.packard@intel.com