From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: saurabhg.gupta@intel.com, jonathan.cavitt@intel.com,
matthew.brost@intel.com, lucas.demarchi@intel.com,
john.c.harrison@intel.com
Subject: [PATCH 1/2] drm/xe/xe_guc_submit: Fix exec queue stop race condition
Date: Thu, 28 Mar 2024 14:33:57 -0700 [thread overview]
Message-ID: <20240328213358.3506490-1-jonathan.cavitt@intel.com> (raw)
Reorder the xe_sched_tdr_queue_imm and set_exec_queue_banned calls in
guc_exec_queue_stop. This prevents a possible race condition between
the two events.
Suggested-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 13b7e195c7b57..294f40ab6aaf1 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1430,8 +1430,8 @@ static void guc_exec_queue_stop(struct xe_guc *guc, struct xe_exec_queue *q)
!xe_sched_job_completed(job)) ||
xe_sched_invalidate_job(job, 2)) {
trace_xe_sched_job_ban(job);
- xe_sched_tdr_queue_imm(&q->guc->sched);
set_exec_queue_banned(q);
+ xe_sched_tdr_queue_imm(&q->guc->sched);
}
}
}
--
2.25.1
next reply other threads:[~2024-03-28 21:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 21:33 Jonathan Cavitt [this message]
2024-03-28 21:33 ` [PATCH 2/2] drm/xe/xe_guc_status: Allow lr exec queues to be banned Jonathan Cavitt
2024-03-29 4:46 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/xe_guc_submit: Fix exec queue stop race condition Patchwork
2024-03-29 4:47 ` ✓ CI.checkpatch: " Patchwork
2024-03-29 4:48 ` ✓ CI.KUnit: " Patchwork
2024-03-29 5:00 ` ✓ CI.Build: " Patchwork
2024-03-29 5:03 ` ✓ CI.Hooks: " Patchwork
2024-03-29 5:19 ` ✓ CI.checksparse: " Patchwork
2024-03-29 6:04 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328213358.3506490-1-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=matthew.brost@intel.com \
--cc=saurabhg.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).