RE: [PATCH] drm/xe: Delete unused GuC submission_state.suspend

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of
> Matthew Brost
> Sent: 25 April 2024 11:18
> To: intel-xe@lists.freedesktop.org
> Cc: Brost, Matthew <matthew.brost@intel.com>
> Subject: [PATCH] drm/xe: Delete unused GuC submission_state.suspend
> 
> GuC submission_state.suspend is unused, delete it.
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 4 ----
> drivers/gpu/drm/xe/xe_guc_types.h  | 9 ---------
>  2 files changed, 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c
> b/drivers/gpu/drm/xe/xe_guc_submit.c
> index c7d38469fb46..4e78610d1591 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -250,7 +250,6 @@ static void primelockdep(struct xe_guc *guc)
>  	fs_reclaim_acquire(GFP_KERNEL);
> 
>  	mutex_lock(&guc->submission_state.lock);
> -	might_lock(&guc->submission_state.suspend.lock);
>  	mutex_unlock(&guc->submission_state.lock);
> 
>  	fs_reclaim_release(GFP_KERNEL);
> @@ -278,9 +277,6 @@ int xe_guc_submit_init(struct xe_guc *guc)
> 
>  	xa_init(&guc->submission_state.exec_queue_lookup);
> 
> -	spin_lock_init(&guc->submission_state.suspend.lock);
> -	guc->submission_state.suspend.context =
> dma_fence_context_alloc(1);
> -
>  	primelockdep(guc);
> 
>  	return drmm_add_action_or_reset(&xe->drm, guc_submit_fini, guc);
> diff --git a/drivers/gpu/drm/xe/xe_guc_types.h
> b/drivers/gpu/drm/xe/xe_guc_types.h
> index 82bd93f7867d..546ac6350a31 100644
> --- a/drivers/gpu/drm/xe/xe_guc_types.h
> +++ b/drivers/gpu/drm/xe/xe_guc_types.h
> @@ -72,15 +72,6 @@ struct xe_guc {
>  		atomic_t stopped;
>  		/** @submission_state.lock: protects submission state */
>  		struct mutex lock;
> -		/** @submission_state.suspend: suspend fence state */
> -		struct {
> -			/** @submission_state.suspend.lock: suspend
> fences lock */
> -			spinlock_t lock;
> -			/** @submission_state.suspend.context: suspend
> fences context */
> -			u64 context;
> -			/** @submission_state.suspend.seqno: suspend
> fences seqno */
> -			u32 seqno;
> -		} suspend;
>  #ifdef CONFIG_PROVE_LOCKING
>  #define NUM_SUBMIT_WQ	256
>  		/** @submission_state.submit_wq_pool: submission
> ordered workqueues pool */

LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

> --
> 2.34.1