From: Jens Axboe <axboe@kernel.dk>
To: Jiufei Xue <jiufei.xue@linux.alibaba.com>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH liburing 1/2] io_uring_enter: add timeout support
Date: Wed, 29 Jul 2020 11:51:10 -0600 [thread overview]
Message-ID: <0f6cdf31-fbec-d447-989d-969bb936838a@kernel.dk> (raw)
In-Reply-To: <1596017415-39101-2-git-send-email-jiufei.xue@linux.alibaba.com>
On 7/29/20 4:10 AM, Jiufei Xue wrote:
> Kernel can handle timeout when feature IORING_FEAT_GETEVENTS_TIMEOUT
> supported. Add two new interfaces: io_uring_wait_cqes2(),
> io_uring_wait_cqe_timeout2() for applications to use this feature.
Why add new new interfaces, when the old ones already pass in the
timeout? Surely they could just use this new feature, instead of the
internal timeout, if it's available?
> diff --git a/src/include/liburing.h b/src/include/liburing.h
> index 0505a4f..6176a63 100644
> --- a/src/include/liburing.h
> +++ b/src/include/liburing.h
> @@ -56,6 +56,7 @@ struct io_uring {
> struct io_uring_sq sq;
> struct io_uring_cq cq;
> unsigned flags;
> + unsigned features;
> int ring_fd;
> };
This breaks the API, as it changes the size of the ring...
--
Jens Axboe
next prev parent reply other threads:[~2020-07-29 17:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 10:10 [PATCH liburing 0/2] add two interfaces for new timeout feature Jiufei Xue
2020-07-29 10:10 ` [PATCH liburing 1/2] io_uring_enter: add timeout support Jiufei Xue
2020-07-29 17:51 ` Jens Axboe [this message]
2020-07-30 2:32 ` Jiufei Xue
2020-07-30 15:28 ` Jens Axboe
2020-07-31 2:12 ` Jiufei Xue
2020-07-31 2:56 ` Jens Axboe
2020-07-31 3:16 ` Jiufei Xue
2020-07-31 3:57 ` Jens Axboe
2020-08-03 3:16 ` Jiufei Xue
2020-08-03 16:41 ` Jens Axboe
2020-08-03 19:16 ` Stefan Metzmacher
2020-08-04 1:29 ` Jiufei Xue
2020-08-04 4:50 ` Jens Axboe
2020-08-04 5:04 ` Jiufei Xue
2020-08-04 5:19 ` Jens Axboe
2020-07-29 10:10 ` [PATCH liburing 2/2] test/timeout: add testcase for new timeout interface Jiufei Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f6cdf31-fbec-d447-989d-969bb936838a@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=jiufei.xue@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).