From: Hrvoje Zeba <zeba.hrvoje@gmail.com>
To: io-uring@vger.kernel.org
Cc: Hrvoje Zeba <zeba.hrvoje@gmail.com>
Subject: [PATCH] io_uring: Remove superfluous check for sqe->off in io_connect()
Date: Mon, 25 Nov 2019 17:09:56 -0500 [thread overview]
Message-ID: <20191125220956.167347-1-zeba.hrvoje@gmail.com> (raw)
This field contains addrlen value and checking to see if it's set
returns -EINVAL.
Signed-off-by: Hrvoje Zeba <zeba.hrvoje@gmail.com>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 8cb8f3898c77..f5e81b5511e1 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1998,7 +1998,7 @@ static int io_connect(struct io_kiocb *req, const struct io_uring_sqe *sqe,
if (unlikely(req->ctx->flags & (IORING_SETUP_IOPOLL|IORING_SETUP_SQPOLL)))
return -EINVAL;
- if (sqe->ioprio || sqe->off || sqe->len || sqe->buf_index ||
+ if (sqe->ioprio || sqe->len || sqe->buf_index ||
sqe->rw_flags)
return -EINVAL;
--
2.24.0
next reply other threads:[~2019-11-25 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 22:09 Hrvoje Zeba [this message]
2019-11-25 22:18 ` [PATCH] io_uring: Remove superfluous check for sqe->off in io_connect() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125220956.167347-1-zeba.hrvoje@gmail.com \
--to=zeba.hrvoje@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).