From: peterz@infradead.org
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] kernel: split task_work_add() into two separate helpers
Date: Mon, 10 Aug 2020 13:37:40 +0200 [thread overview]
Message-ID: <20200810113740.GR2674@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200808183439.342243-2-axboe@kernel.dk>
On Sat, Aug 08, 2020 at 12:34:38PM -0600, Jens Axboe wrote:
> Some callers may need to make signaling decisions based on the state
> of the targeted task, and that can only safely be done post adding
> the task_work to the task. Split task_work_add() into:
>
> __task_work_add() - adds the work item
> __task_work_notify() - sends the notification
>
> No functional changes in this patch.
Might be nice to mention __task_work_add() is now inline.
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: stable@vger.kernel.org # v5.7+
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> ---
> include/linux/task_work.h | 19 ++++++++++++++++
> kernel/task_work.c | 48 +++++++++++++++++++++------------------
> 2 files changed, 45 insertions(+), 22 deletions(-)
> +struct callback_head work_exited = {
> + .next = NULL /* all we need is ->next == NULL */
> +};
Would it make sense to make this const ? Esp. with the thing exposed,
sticking it in R/O memory might avoid a mistake somewhere.
next prev parent reply other threads:[~2020-08-10 11:37 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 18:34 [PATCHSET 0/2] io_uring: use TWA_SIGNAL more carefully Jens Axboe
2020-08-08 18:34 ` [PATCH 1/2] kernel: split task_work_add() into two separate helpers Jens Axboe
2020-08-10 11:37 ` peterz [this message]
2020-08-10 15:01 ` Jens Axboe
2020-08-10 15:28 ` peterz
2020-08-10 17:51 ` Jens Axboe
2020-08-10 19:53 ` Peter Zijlstra
2020-08-08 18:34 ` [PATCH 2/2] io_uring: use TWA_SIGNAL for task_work if the task isn't running Jens Axboe
2020-08-10 11:42 ` peterz
2020-08-10 15:02 ` Jens Axboe
2020-08-10 19:21 ` Jens Axboe
2020-08-10 20:12 ` Peter Zijlstra
2020-08-10 20:13 ` Jens Axboe
2020-08-10 20:25 ` Jens Axboe
2020-08-10 20:32 ` Peter Zijlstra
2020-08-10 20:35 ` Jens Axboe
2020-08-10 20:35 ` Jann Horn
2020-08-10 21:06 ` Jens Axboe
2020-08-10 21:10 ` Peter Zijlstra
2020-08-10 21:12 ` Jens Axboe
2020-08-10 21:26 ` Jann Horn
2020-08-10 21:28 ` Jens Axboe
2020-08-10 22:01 ` Jens Axboe
2020-08-10 22:41 ` Jann Horn
2020-08-11 1:25 ` Jens Axboe
2020-08-11 6:45 ` Oleg Nesterov
2020-08-11 6:56 ` Peter Zijlstra
2020-08-11 7:14 ` Oleg Nesterov
2020-08-11 7:26 ` Oleg Nesterov
2020-08-11 7:49 ` Peter Zijlstra
2020-08-11 7:45 ` Peter Zijlstra
2020-08-11 8:10 ` Oleg Nesterov
2020-08-11 13:06 ` Jens Axboe
2020-08-11 14:05 ` Oleg Nesterov
2020-08-11 14:12 ` Jens Axboe
2020-08-10 21:27 ` Jens Axboe
2020-08-10 20:16 ` Jens Axboe
2020-08-13 16:25 ` Sasha Levin
2020-08-19 23:57 ` Sasha Levin
2020-08-19 23:59 ` Jens Axboe
2020-08-20 0:02 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810113740.GR2674@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).