From: Stefano Garzarella <sgarzare@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Christian Brauner <christian.brauner@ubuntu.com>,
Jann Horn <jannh@google.com>, Jeff Moyer <jmoyer@redhat.com>,
linux-fsdevel@vger.kernel.org, Sargun Dhillon <sargun@sargun.me>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
linux-kernel@vger.kernel.org, Aleksa Sarai <asarai@suse.de>,
io-uring@vger.kernel.org
Subject: Re: [PATCH v4 2/3] io_uring: add IOURING_REGISTER_RESTRICTIONS opcode
Date: Thu, 27 Aug 2020 09:12:27 +0200 [thread overview]
Message-ID: <20200827071227.tozlhvidn3iet6xy@steredhat.lan> (raw)
In-Reply-To: <202008261245.245E36654@keescook>
On Wed, Aug 26, 2020 at 12:46:24PM -0700, Kees Cook wrote:
> On Thu, Aug 13, 2020 at 05:32:53PM +0200, Stefano Garzarella wrote:
> > +/*
> > + * io_uring_restriction->opcode values
> > + */
> > +enum {
> > + /* Allow an io_uring_register(2) opcode */
> > + IORING_RESTRICTION_REGISTER_OP,
> > +
> > + /* Allow an sqe opcode */
> > + IORING_RESTRICTION_SQE_OP,
> > +
> > + /* Allow sqe flags */
> > + IORING_RESTRICTION_SQE_FLAGS_ALLOWED,
> > +
> > + /* Require sqe flags (these flags must be set on each submission) */
> > + IORING_RESTRICTION_SQE_FLAGS_REQUIRED,
> > +
> > + IORING_RESTRICTION_LAST
> > +};
>
> Same thought on enum literals, but otherwise, looks good:
Sure, I'll fix the enum in the next version.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Thanks for the review,
Stefano
next prev parent reply other threads:[~2020-08-27 7:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 15:32 [PATCH v4 0/3] io_uring: add restrictions to support untrusted applications and guests Stefano Garzarella
2020-08-13 15:32 ` [PATCH v4 1/3] io_uring: use an enumeration for io_uring_register(2) opcodes Stefano Garzarella
2020-08-26 19:40 ` Kees Cook
2020-08-26 19:43 ` Kees Cook
2020-08-26 19:52 ` Andreas Dilger
2020-08-27 7:11 ` Stefano Garzarella
2020-08-13 15:32 ` [PATCH v4 2/3] io_uring: add IOURING_REGISTER_RESTRICTIONS opcode Stefano Garzarella
2020-08-26 19:46 ` Kees Cook
2020-08-27 7:12 ` Stefano Garzarella [this message]
2020-08-13 15:32 ` [PATCH v4 3/3] io_uring: allow disabling rings during the creation Stefano Garzarella
2020-08-26 19:50 ` Kees Cook
2020-08-27 7:18 ` Stefano Garzarella
2020-08-27 15:04 ` Kees Cook
2020-08-25 15:20 ` [PATCH v4 0/3] io_uring: add restrictions to support untrusted applications and guests Stefano Garzarella
2020-08-26 16:47 ` Jens Axboe
2020-08-26 19:40 ` Kees Cook
2020-08-27 7:24 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827071227.tozlhvidn3iet6xy@steredhat.lan \
--to=sgarzare@redhat.com \
--cc=asarai@suse.de \
--cc=axboe@kernel.dk \
--cc=christian.brauner@ubuntu.com \
--cc=io-uring@vger.kernel.org \
--cc=jannh@google.com \
--cc=jmoyer@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sargun@sargun.me \
--cc=stefanha@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).