From: Lu Hongfei <luhongfei@vivo.com>
To: Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] io_uring: Add {} to maintain consistency in code format
Date: Fri, 30 Jun 2023 14:25:12 +0800 [thread overview]
Message-ID: <20230630062512.10724-1-luhongfei@vivo.com> (raw)
In io_issue_sqe, the if (ret == IOU_OK) branch uses {}, so to maintain code
format consistency, it is better to add {} in the else branch.
Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
io_uring/io_uring.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index e8096d502a7c..335ba8d49d74 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1877,8 +1877,9 @@ static int io_issue_sqe(struct io_kiocb *req, unsigned int issue_flags)
io_req_complete_defer(req);
else
io_req_complete_post(req, issue_flags);
- } else if (ret != IOU_ISSUE_SKIP_COMPLETE)
+ } else if (ret != IOU_ISSUE_SKIP_COMPLETE) {
return ret;
+ }
/* If the op doesn't have a file, we're not polling for it */
if ((req->ctx->flags & IORING_SETUP_IOPOLL) && def->iopoll_queue)
--
2.39.0
reply other threads:[~2023-06-30 6:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630062512.10724-1-luhongfei@vivo.com \
--to=luhongfei@vivo.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).