From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
io-uring Mailing List <io-uring@vger.kernel.org>,
Eli Schwartz <eschwartz93@gmail.com>,
Pavel Begunkov <asml.silence@gmail.com>
Subject: Re: [PATCH liburing 3/4] tests: add tests for zerocopy send and notifications
Date: Tue, 26 Jul 2022 16:35:41 +0700 [thread overview]
Message-ID: <55b6d481ea394ab6e18d455a10e0c7ed@gnuweeb.org> (raw)
In-Reply-To: <eb9f8e37-a3b5-0b87-4f90-7ec80772e3fb@kernel.dk>
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Subject: [PATCH] helpers.h: Kill T_EXIT_ERROR because it's not used
This value is not used anywhere in liburing tests and we are not
going to make a distinction between FAIL and ERROR. Kill it to
avoid confusion in choosing them. Just always use T_EXIT_FAIL
whenever we fail.
Cc: Eli Schwartz <eschwartz93@gmail.com>
Link: https://lore.kernel.org/io-uring/eb9f8e37-a3b5-0b87-4f90-7ec80772e3fb@kernel.dk
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
On Mon, 25 Jul 2022 17:37:03 -0600, Jens Axboe wrote:
> I think we should kill that, it just causes confusion and I generally
> hate adding infrastructure that isn't even being used.
The killing patch below...
test/helpers.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/test/helpers.h b/test/helpers.h
index fbfd7d1..6d5726c 100644
--- a/test/helpers.h
+++ b/test/helpers.h
@@ -20,7 +20,6 @@ enum t_test_result {
T_EXIT_PASS = 0,
T_EXIT_FAIL = 1,
T_EXIT_SKIP = 77,
- T_EXIT_ERROR = 99,
};
/*
base-commit: 30a20795d7e4f300c606c6a2aa0a4c9492882d1d
--
Ammar Faizi
next prev parent reply other threads:[~2022-07-26 9:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 10:03 [PATCH liburing 0/4] zerocopy send headers and tests Pavel Begunkov
2022-07-25 10:03 ` [PATCH liburing 1/4] io_uring.h: sync with kernel for zc send and notifiers Pavel Begunkov
2022-07-25 10:03 ` [PATCH liburing 2/4] liburing: add zc send and notif helpers Pavel Begunkov
2022-07-25 10:20 ` Ammar Faizi
2022-07-25 11:18 ` Pavel Begunkov
2022-07-25 10:03 ` [PATCH liburing 3/4] tests: add tests for zerocopy send and notifications Pavel Begunkov
2022-07-25 10:35 ` Ammar Faizi
2022-07-25 11:28 ` Pavel Begunkov
2022-07-25 12:08 ` Ammar Faizi
2022-07-25 14:07 ` Pavel Begunkov
2022-07-25 18:55 ` Eli Schwartz
2022-07-25 23:37 ` Jens Axboe
2022-07-26 9:35 ` Ammar Faizi [this message]
2022-07-25 10:03 ` [PATCH liburing 4/4] examples: add a zerocopy send example Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55b6d481ea394ab6e18d455a10e0c7ed@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=eschwartz93@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).