From: Jens Axboe <axboe@kernel.dk>
To: Andres Freund <andres@anarazel.de>
Cc: Phil Elwell <phil@raspberrypi.com>,
asml.silence@gmail.com, david@fromorbit.com, hch@lst.de,
io-uring@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-xfs@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] io_uring: Use io_schedule* in cqring wait
Date: Mon, 24 Jul 2023 11:44:32 -0600 [thread overview]
Message-ID: <5f303931-40d3-2133-9085-62440f8b0666@kernel.dk> (raw)
In-Reply-To: <20230724172432.mcua7vewxrs5cvlg@awork3.anarazel.de>
On 7/24/23 11:24?AM, Andres Freund wrote:
> Hi,
>
> On 2023-07-24 09:16:56 -0700, Andres Freund wrote:
>> Building a kernel to test with the patch applied, will reboot into it once the
>> call I am on has finished. Unfortunately the performance difference didn't
>> reproduce nicely in VM...
>
> Performance is good with the patch applied. Results are slightly better even,
> but I think that's likely just noise.
Could be - it's avoiding a few function calls and the flush, but would
probably have to be a pretty targeted test setup to find that for
storage IO. Thanks for testing!
--
Jens Axboe
next prev parent reply other threads:[~2023-07-24 17:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 15:35 [PATCH] io_uring: Use io_schedule* in cqring wait Phil Elwell
2023-07-24 15:48 ` Greg KH
2023-07-24 15:50 ` Jens Axboe
2023-07-24 15:58 ` Jens Axboe
2023-07-24 16:07 ` Phil Elwell
2023-07-24 16:08 ` Jens Axboe
2023-07-24 16:48 ` Phil Elwell
2023-07-24 18:22 ` Jens Axboe
2023-07-24 19:22 ` Pavel Begunkov
2023-07-24 20:27 ` Jeff Moyer
2023-07-24 15:48 ` Jens Axboe
2023-07-24 16:16 ` Andres Freund
2023-07-24 16:20 ` Jens Axboe
2023-07-24 17:24 ` Andres Freund
2023-07-24 17:44 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-18 19:49 [PATCHSET v2 0/5] Improve async iomap DIO performance Jens Axboe
2023-07-18 19:49 ` [PATCH] io_uring: Use io_schedule* in cqring wait Jens Axboe
2023-07-18 19:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f303931-40d3-2133-9085-62440f8b0666@kernel.dk \
--to=axboe@kernel.dk \
--cc=andres@anarazel.de \
--cc=asml.silence@gmail.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).