From: Christoph Hellwig <hch@infradead.org>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: Lu Hongfei <luhongfei@vivo.com>, Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH] io_uring: Redefined the meaning of io_alloc_async_data's return value
Date: Mon, 10 Jul 2023 22:06:22 -0700 [thread overview]
Message-ID: <ZKzjTg1xaoikN9Hh@infradead.org> (raw)
In-Reply-To: <87o7kjr9d9.fsf@suse.de>
On Mon, Jul 10, 2023 at 12:58:58PM -0400, Gabriel Krisman Bertazi wrote:
> practice to change the symbol, making the change hard to miss. Or
> make the function return int instead of bool, which preserves the
> interface and is a common C idiom. Or leave it as it is, which is quite
> readable already..
Yeah, returning -ENOMEM and 0 would make a lot more sense here. But I'd
only change it if we have any good reason to touch the interface anyway.
prev parent reply other threads:[~2023-07-11 5:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 9:09 [PATCH] io_uring: Redefined the meaning of io_alloc_async_data's return value Lu Hongfei
2023-07-10 16:58 ` Gabriel Krisman Bertazi
2023-07-10 17:02 ` Jens Axboe
2023-07-11 5:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKzjTg1xaoikN9Hh@infradead.org \
--to=hch@infradead.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=krisman@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luhongfei@vivo.com \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).