From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] io-wq: remove extra space characters
Date: Tue, 19 Nov 2019 08:45:25 -0700 [thread overview]
Message-ID: <ac841162-db41-0c8b-6ff8-d5b956961582@kernel.dk> (raw)
In-Reply-To: <20191119062216.qhxmnrt2rdioirja@kili.mountain>
On 11/18/19 11:22 PM, Dan Carpenter wrote:
> These lines are indented an extra space character.
Thanks, applied.
> We often see this where the lines after a comment are indented one
> space extra. I don't know if it's an editor thing maybe?
I think I can explain that. I recently decided to try and use the
vim auto-indent, to see if it'd make my life a little easier to
save on typing. Unfortunately it has a bug where it indents that
extra space following a comment form like:
/*
* bla bla
*/
which is exactly what happened here. As diff doesn't show that
as extra whitespace you can miss that it happened.
--
Jens Axboe
prev parent reply other threads:[~2019-11-19 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 6:22 [PATCH] io-wq: remove extra space characters Dan Carpenter
2019-11-19 15:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac841162-db41-0c8b-6ff8-d5b956961582@kernel.dk \
--to=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=io-uring@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).