From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org
Cc: Hao Xu <haoxu@linux.alibaba.com>
Subject: Re: [PATCH liburing v2] tests: test early-submit link fails
Date: Tue, 31 Aug 2021 19:15:39 +0100 [thread overview]
Message-ID: <dc45d3e2-b1b1-b5df-ff8d-a886cae261d2@gmail.com> (raw)
In-Reply-To: <d813efa3-4391-2e3e-54d4-a9dc3e346511@kernel.dk>
On 8/31/21 6:03 PM, Jens Axboe wrote:
> On 8/31/21 9:49 AM, Pavel Begunkov wrote:
>> Add a whole bunch of tests for when linked requests fail early during
>> submission.
>
> Applied, but remember to check write(2) returns:
>
> submit-link-fail.c: In function ‘test_underprep_fail’:
> submit-link-fail.c:80:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 80 | write(fds[1], buffer, sizeof(buffer));
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
My bad. Interesting why my gcc 11 doesn't complain.
--
Pavel Begunkov
next prev parent reply other threads:[~2021-08-31 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 15:49 [PATCH liburing v2] tests: test early-submit link fails Pavel Begunkov
2021-08-31 17:03 ` Jens Axboe
2021-08-31 18:15 ` Pavel Begunkov [this message]
2021-09-01 18:04 ` Hao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc45d3e2-b1b1-b5df-ff8d-a886cae261d2@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=haoxu@linux.alibaba.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).