From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97007C33C9E for ; Thu, 9 Jan 2020 01:02:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64CC42067D for ; Thu, 9 Jan 2020 01:02:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="Tn614v3I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbgAIBCp (ORCPT ); Wed, 8 Jan 2020 20:02:45 -0500 Received: from mail-pf1-f176.google.com ([209.85.210.176]:41971 "EHLO mail-pf1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726913AbgAIBCp (ORCPT ); Wed, 8 Jan 2020 20:02:45 -0500 Received: by mail-pf1-f176.google.com with SMTP id w62so2479240pfw.8 for ; Wed, 08 Jan 2020 17:02:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ohlEOH5XWZ6A1s4JDpVP+2TOtl9UGDxWVMf8fpmYopY=; b=Tn614v3IQX5DPzGvONLnn2DMWx1qlDTwcNP7VpUtT/crVYqRW07tYmWfDEq554ngES t+REJ3IqPUkviApcsxFbnFjzY746dDn/epjM7RbAYbeZxFVelCAz6fYskY2AkcdXXivD bCjJb4JwtVe9yZghxC/3O6WcrAy+oARFugfxxhdS0UltabUtrfvxhIPMCPiqZ2STnx69 ULljbUD60XjcYAcvODYbfZaY/HAX8SzfFql48ykJHHmthndK+wGzkuTps6YBhYY2JJDI tg0KGqaOa5SE8X2dZeeRLtdluwaGiLgP+VqZYrRiArPnPMqC3i2XAb6BCUqEljGXOlVA OHkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ohlEOH5XWZ6A1s4JDpVP+2TOtl9UGDxWVMf8fpmYopY=; b=sPu/Y0849MCOXVuZZZwODiG3C+WxnAxCWmNqcuM4rQOciSufPcV7U4kWOuc0O7Wj6x sVp1+RLwgEiC8KkmBBrbdmzL0Q0tyOOJBpRnGaxjWbPtVMbbty7XyljV143kStaSmvRP H4WDTpKR0YQTpkmy8zMnhCBYPEcSlAKy0Hiep3JT8PMoihT9m2tLv8T3o3fCdhRmaaAv bJvIJ02rvD8q0IEqGpbuFnWDYboVWxIE1Ms0a4FrnnV0QyWGbJMkDFzPSSNhgFbxSZQa iD+NeT2uR9Er1vPjGmR4gyNm97eumzKysKKFRFFHl32TMGnCC8OWMEDbGlDeWwDNlpnP ktzg== X-Gm-Message-State: APjAAAW73g6AxwS7GU+iU5+BFKdzD0wWycgqtOPuKXlcTyhP/DeedwQ2 oLQiArwLFXfdvtmLw9mbLaRuPA== X-Google-Smtp-Source: APXvYqy6eI6tbMcDpdYa1V7JRnmd3NXhhV8t8X/dcg/efqJu/i03zdPKcn/Tfg9NI0cNiPEHz4dm7w== X-Received: by 2002:a63:134e:: with SMTP id 14mr8409191pgt.115.1578531764003; Wed, 08 Jan 2020 17:02:44 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id a6sm4730969pgg.25.2020.01.08.17.02.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2020 17:02:43 -0800 (PST) Subject: Re: [PATCHSET v2 0/6] io_uring: add support for open/close To: Stefan Metzmacher , io-uring@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk References: <20200107170034.16165-1-axboe@kernel.dk> <4adb30f4-2ab3-6029-bc94-c72736b9004a@kernel.dk> <4dffd58e-5602-62d5-d1af-343c4a091ed9@samba.org> From: Jens Axboe Message-ID: Date: Wed, 8 Jan 2020 18:02:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <4dffd58e-5602-62d5-d1af-343c4a091ed9@samba.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 1/8/20 4:05 PM, Stefan Metzmacher wrote: > Am 08.01.20 um 23:57 schrieb Jens Axboe: >> On 1/8/20 2:17 PM, Stefan Metzmacher wrote: >>> Am 07.01.20 um 18:00 schrieb Jens Axboe: >>>> Sending this out separately, as I rebased it on top of the work.openat2 >>>> branch from Al to resolve some of the conflicts with the differences in >>>> how open flags are built. >>> >>> Now that you rebased on top of openat2, wouldn't it be better to add >>> openat2 that to io_uring instead of the old openat call? >> >> The IORING_OP_OPENAT already exists, so it would probably make more sense >> to add IORING_OP_OPENAT2 alongside that. Or I could just change it. Don't >> really feel that strongly about it, I'll probably just add openat2 and >> leave openat alone, openat will just be a wrapper around openat2 anyway. > > Great, thanks! Here: https://git.kernel.dk/cgit/linux-block/log/?h=for-5.6/io_uring-vfs Not tested yet, will wire this up in liburing and write a test case as well. -- Jens Axboe