From: Jens Axboe <axboe@kernel.dk>
To: Josh Triplett <josh@joshtriplett.org>,
Pavel Begunkov <asml.silence@gmail.com>
Cc: io-uring@vger.kernel.org
Subject: Re: [WIP PATCH] io_uring: Support opening a file into the fixed-file table
Date: Wed, 15 Jul 2020 14:54:38 -0600 [thread overview]
Message-ID: <ee9a8616-0fd5-af8f-fb75-882b23714e02@kernel.dk> (raw)
In-Reply-To: <20200715204614.GB350138@localhost>
On 7/15/20 2:46 PM, Josh Triplett wrote:
>>> + file = do_filp_open(open->dfd, open->filename, &op);
>>> + if (IS_ERR(file)) {
>>> + ret = PTR_ERR(file);
>>> + } else {
>>> + fsnotify_open(file);
>>> + ret = io_sqe_files_add_new(req->ctx, open->open_fixed_idx, file);
>>> + if (ret)
>>> + fput(file);
>>> + }
>>> +err:
>>> + putname(open->filename);
>>> + req->flags &= ~REQ_F_NEED_CLEANUP;
>>> + if (ret < 0)
>>> + req_set_fail_links(req);
>>> + io_cqring_add_event(req, ret);
>>> + io_put_req(req);
>>
>> These 2 lines are better to be replace with (since 5.9):
>>
>> io_req_complete(req, ret);
>
> This was directly copied from the same code in io_openat2.
You're probably using current -git or something like that, the patch
would be best against for-5.9/io_uring - that's what's queued up for
5.9, and it does use io_req_complete() consistently throughout.
--
Jens Axboe
prev parent reply other threads:[~2020-07-15 20:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 21:08 [WIP PATCH] io_uring: Support opening a file into the fixed-file table Josh Triplett
2020-07-14 21:16 ` [WIP PATCH] liburing: Support IORING_OP_OPENAT2_FIXED_FILE Josh Triplett
2020-07-14 22:59 ` [WIP PATCH] io_uring: Support opening a file into the fixed-file table Clay Harris
2020-07-15 0:42 ` Josh Triplett
2020-07-15 2:32 ` Clay Harris
2020-07-15 21:04 ` josh
2020-07-15 16:07 ` Jens Axboe
2020-07-15 19:54 ` Pavel Begunkov
2020-07-15 20:46 ` Josh Triplett
2020-07-15 20:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee9a8616-0fd5-af8f-fb75-882b23714e02@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=josh@joshtriplett.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).