kernel-hardening.lists.openwall.com archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Garnier <thgarnie@chromium.org>,
	Kernel Hardening <kernel-hardening@lists.openwall.com>,
	Kristen Carlson Accardi <kristen@linux.intel.com>,
	Kees Cook <keescook@chromium.org>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 04/11] x86/entry/64: Adapt assembly for PIE support
Date: Tue, 6 Aug 2019 10:30:32 +0200	[thread overview]
Message-ID: <20190806083032.GN2332@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190806050851.GA25897@zn.tnic>

On Tue, Aug 06, 2019 at 07:08:51AM +0200, Borislav Petkov wrote:
> On Mon, Aug 05, 2019 at 10:50:30AM -0700, Thomas Garnier wrote:
> > I saw that %rdx was used for temporary usage and restored before the
> > end so I assumed that it was not an option.
> 
> PUSH_AND_CLEAR_REGS saves all regs earlier so I think you should be
> able to use others. Like SAVE_AND_SWITCH_TO_KERNEL_CR3/RESTORE_CR3, for
> example, uses %r15 and %r14.

AFAICT the CONFIG_DEBUG_ENTRY thing he's changing is before we setup
pt_regs.

Also consider the UNWIND hint that's in there, it states we only have
the IRET frame on stack, not a full regs set.

  reply	other threads:[~2019-08-06  8:31 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 19:12 [PATCH v9 00/11] x86: PIE support to extend KASLR randomization Thomas Garnier
2019-07-30 19:12 ` [PATCH v9 01/11] x86/crypto: Adapt assembly for PIE support Thomas Garnier
2019-08-05 16:32   ` Borislav Petkov
2019-08-05 16:54     ` Kees Cook
2019-08-05 17:27       ` Borislav Petkov
2019-08-05 17:53         ` Thomas Garnier
2019-07-30 19:12 ` [PATCH v9 02/11] x86: Add macro to get symbol address " Thomas Garnier
2019-07-30 19:12 ` [PATCH v9 03/11] x86: relocate_kernel - Adapt assembly " Thomas Garnier
2019-07-30 19:12 ` [PATCH v9 04/11] x86/entry/64: " Thomas Garnier
2019-08-05 17:28   ` Borislav Petkov
2019-08-05 17:50     ` Thomas Garnier
2019-08-06  5:08       ` Borislav Petkov
2019-08-06  8:30         ` Peter Zijlstra [this message]
2019-08-06 12:35           ` Borislav Petkov
2019-08-06 13:59     ` Steven Rostedt
2019-08-06 15:35       ` Borislav Petkov
2019-07-30 19:12 ` [PATCH v9 05/11] x86: pm-trace - " Thomas Garnier
2019-07-30 19:12 ` [PATCH v9 06/11] x86/CPU: " Thomas Garnier
2019-07-30 19:12 ` [PATCH v9 07/11] x86/acpi: " Thomas Garnier
2019-07-30 19:12 ` [PATCH v9 08/11] x86/boot/64: " Thomas Garnier
2019-08-09 17:30   ` Borislav Petkov
2019-10-29 21:29     ` Thomas Garnier
2019-07-30 19:12 ` [PATCH v9 09/11] x86/power/64: " Thomas Garnier
2019-07-30 19:12 ` [PATCH v9 10/11] x86/paravirt: " Thomas Garnier
2019-07-31 12:53   ` Peter Zijlstra
2019-08-12 12:55     ` Borislav Petkov
2019-10-29 21:30       ` Thomas Garnier
2019-07-30 19:12 ` [PATCH v9 11/11] x86/alternatives: " Thomas Garnier
2019-08-12 13:57   ` Borislav Petkov
2019-10-29 21:31     ` Thomas Garnier
2019-08-06 15:43 ` [PATCH v9 00/11] x86: PIE support to extend KASLR randomization Borislav Petkov
2019-08-06 15:50   ` Peter Zijlstra
2019-08-29 19:55     ` Thomas Garnier
2019-09-06 23:22       ` Thomas Garnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190806083032.GN2332@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=kristen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=thgarnie@chromium.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).