From: Oscar Carter <oscar.carter@gmx.com>
To: Kees Cook <keescook@chromium.org>, Allen <allen.lkml@gmail.com>
Cc: Oscar Carter <oscar.carter@gmx.com>,
Kernel Hardening <kernel-hardening@lists.openwall.com>
Subject: Re: Clarification about the series to modernize the tasklet api
Date: Sat, 18 Jul 2020 14:21:45 +0200 [thread overview]
Message-ID: <20200718122145.GA3153@ubuntu> (raw)
In-Reply-To: <202007130914.E9157B3@keescook>
On Mon, Jul 13, 2020 at 09:16:12AM -0700, Kees Cook wrote:
> On Mon, Jul 13, 2020 at 02:55:22PM +0530, Allen wrote:
> > Oscar,
> > >
> > > I'm working to modernize the tasklet api but I don't understand the reply
> > > to the patch 12/16 [1] of the patch series of Romain Perier [2].
> >
> > Am working on the same too. I did try reaching out to Romain but not luck.
> > Let's hope we are not duplicating efforts.
Don't worry. The work done by me for the moment has been to read all the Romain
patches.
> > > If this patch is combined with the first one, and the function prototypes
> > > are not changed accordingly and these functions don't use the from_tasklet()
> > > helper, all the users that use the DECLARE_TASKLET macro don't pass the
> > > correct argument to the .data field.
> > >
> > > #define DECLARE_TASKLET(name, func, data) \
> > > -struct tasklet_struct name = { NULL, 0, ATOMIC_INIT(0), func, data }
> > > +struct tasklet_struct name = { NULL, 0, ATOMIC_INIT(0), (TASKLET_FUNC_TYPE)func, (TASKLET_DATA_TYPE)&name }
> > >
> >
> > Ideally this above bit should have been part of the first patch.
>
> Right, the idea was to have a single patch that contained all the
> infrastructure changes to support the conversion patches.
Ok, thanks for the explanation.
> --
> Kees Cook
Thanks,
Oscar Carter
prev parent reply other threads:[~2020-07-18 12:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 17:42 Clarification about the series to modernize the tasklet api Oscar Carter
2020-07-13 9:25 ` Allen
2020-07-13 10:24 ` Allen
2020-07-13 16:27 ` Kees Cook
2020-07-14 5:09 ` Allen
2020-07-18 12:34 ` Oscar Carter
2020-07-14 0:02 ` Kees Cook
2020-07-14 5:12 ` Allen
2020-07-14 14:27 ` Allen
2020-07-14 23:20 ` Kees Cook
2020-07-15 7:34 ` Allen
2020-07-15 14:51 ` Allen
2020-07-15 15:14 ` Kees Cook
2020-07-15 15:21 ` Allen
2020-07-15 15:29 ` Kees Cook
2020-07-15 15:33 ` Allen
2020-07-13 16:16 ` Kees Cook
2020-07-18 12:21 ` Oscar Carter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200718122145.GA3153@ubuntu \
--to=oscar.carter@gmx.com \
--cc=allen.lkml@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).