From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B23A5CA9EC9 for ; Mon, 4 Nov 2019 21:39:00 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 01F0B20B7C for ; Mon, 4 Nov 2019 21:38:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AMgSst2h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01F0B20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17276-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 24219 invoked by uid 550); 4 Nov 2019 21:38:54 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 24199 invoked from network); 4 Nov 2019 21:38:54 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=erA0+CgO32nkALAW/U97P1GwaRL1ou+VA5YnrGmuWIY=; b=AMgSst2hoIv0GZSG/6Hv3sj7G4QTMHoXZaK+uecCN92VkYk2ZpXGLlGKNE7LaQkMOV GALbiSTH4QXZuxCs4vXVQ+PvBEvuBmB7k5aqf+G9gnmvHWB5/Y+uNebLr8WkNd+bS+Ov /XXES1wI9li/uMeZkpl2e89se5snh4JkYGrWHWMFeboxhZVboLE1Ab4qQKsBrgjgaJ0Z TPALZl6SFGfHwCWeRXmzVYpIwJ+aRCFQbHaYCGtjIRAIEY7ObGDK19pVPN3DP2bzseFq kO3Sq+THrsVH8U3L8DmX49sKk84SksyJMDaTiPQHmYPUwA9Od1QsJS2NmYqwVYjSpzCB i+5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=erA0+CgO32nkALAW/U97P1GwaRL1ou+VA5YnrGmuWIY=; b=tLZZbNAJvhGe0xn+4Ve2gTPY4xwBnQKH1ZnoEzwsJhuX9FBu/3Q9+yt2//mda5VZCL v5yLsC7OoILdkIKosVldy2e4kqCyCfo8Nw7nDKNanwlIEnAtRoMyFT1XhqFglh83zmBY 97uo2FE0ZC9Tb24ZlhnNsaW8etyxrJF2iMnMcimZMPnKCCoxeA3np1mP5hLix+soRn+c pR42+ojzElB1SNpt332lkp2hos3z6reisK9nTEGpygztJadWouYgCSahvjnlIxD0aGL/ /CcWAebcdCkdpHTmaGAAUpUqrlhKBAvDH2c7qpHaCy6IoKiYOmVX0M3HhgZmHoNFdm22 3xNg== X-Gm-Message-State: APjAAAWTtjLFCkPf4o6GuFFn/wnJUlUV1Oerd+d05hjknEux08l5wWxU +U9aCB3NrFmm0v1jy8+K0q3FIZaVRQw48xcoOd+buQ== X-Google-Smtp-Source: APXvYqwHIA8tjMB/idsGTHUTWfDb2R4/Q6AYLqiE/ovPTmnmanOsh2FI1AtdGkwKNIfH3EsSyXxnypTSqw/H2MHfj8Y= X-Received: by 2002:a1f:7d88:: with SMTP id y130mr12696794vkc.71.1572903521740; Mon, 04 Nov 2019 13:38:41 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-14-samitolvanen@google.com> <02c56a5273f94e9d832182f1b3cb5097@www.loen.fr> In-Reply-To: <02c56a5273f94e9d832182f1b3cb5097@www.loen.fr> From: Sami Tolvanen Date: Mon, 4 Nov 2019 13:38:30 -0800 Message-ID: Subject: Re: [PATCH v4 13/17] arm64: preserve x18 when CPU is suspended To: Marc Zyngier Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" On Mon, Nov 4, 2019 at 5:20 AM Marc Zyngier wrote: > > ENTRY(cpu_do_suspend) > > mrs x2, tpidr_el0 > > @@ -73,6 +75,9 @@ alternative_endif > > stp x8, x9, [x0, #48] > > stp x10, x11, [x0, #64] > > stp x12, x13, [x0, #80] > > +#ifdef CONFIG_SHADOW_CALL_STACK > > + str x18, [x0, #96] > > +#endif > > Do we need the #ifdefery here? We didn't add that to the KVM path, > and I'd feel better having a single behaviour, specially when > NR_CTX_REGS is unconditionally sized to hold 13 regs. I'm fine with dropping the ifdefs here in v5 unless someone objects to this. Sami