From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E964DCA9ECB for ; Thu, 31 Oct 2019 17:42:48 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 426862083E for ; Thu, 31 Oct 2019 17:42:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vyAZGLuQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 426862083E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17208-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 21753 invoked by uid 550); 31 Oct 2019 17:42:41 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 21733 invoked from network); 31 Oct 2019 17:42:41 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SpMt9swBFV/X7pJxY11yJxvoU/jl5TYZqkYEwxVo1zk=; b=vyAZGLuQJaP6UmPU/5OivZeIeCWgYHlNvqLsuh7U3yYJqNwBg3VduUAZbxG7Wh6UWt vR9hiusZOPdTKmpPzcbCdthcVtfAuVWCA/M8pStelbzfHpRETEdtgYoVIO74pLVcS5Aj PDux1c/zr+9UcdqYc/u8vkoVsM0YeYHd9+PtmsdPd6I9nLItOy76IJT1irNZ7ZvnLPOp Awz0G6XV3jDbzYKy0ICsWxla4idyK6XrPywrZoHibV+ewA3guRirwYmw7BYI3lR697k/ 6y0spqBrB465HxukOz7+BvekqO5c7tmGdGe9sOFhPb3/TuqkcTuslnkiueSXTjL7kZ2a Exew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SpMt9swBFV/X7pJxY11yJxvoU/jl5TYZqkYEwxVo1zk=; b=N+w/xkL/buQ4ZjVhW3uASrevT9jo/mg1hy1eRBI8QbwKjVZqTzX2/662WELpDI7NGs xSc1ZE859VNmFZmob3VyTfnqvoyoKtgRR9le05Ee534MuHl1s7ehefP1PGMHl5dPqJdz 9dWPPQtz6pmSqyLD1nT7twW/K+Fy92y8QcADIysyV/jmRAiUbKuzd9DA2W0bdM/VpP08 RWlulu90p/0cOwDmnNyqsd3LIv9G8JBxdsqmVI82lfCcrlVP/uhNlQ8yYWFYlMx3aM1X B+auxWkuOxJBD20J3iMmvrL+HTb3sb5AhqyvfGhHqWgw20SG0thaczs2ndE+wJFy2+oY EKpw== X-Gm-Message-State: APjAAAXgQNotyNXYR4roeG8JZF7W6w4ZjZRbDrPFUrEz0njqelH/rs8t dTimm+030xtlFGQ0sC2nEtt8XjrNULfYVds013Ac5g== X-Google-Smtp-Source: APXvYqw74Dsa5tbwvZVY6ubm3mq6Ol0GpZBf3HyKWvRWHEbC8fAxc8l0X7gBK5dChGcDSWL/yjwxE6D5ZDxmwT29ntI= X-Received: by 2002:a67:ed8b:: with SMTP id d11mr3309159vsp.104.1572543748924; Thu, 31 Oct 2019 10:42:28 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-14-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Thu, 31 Oct 2019 10:42:17 -0700 Message-ID: Subject: Re: [PATCH v3 13/17] arm64: preserve x18 when CPU is suspended To: Nick Desaulniers Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" On Thu, Oct 31, 2019 at 10:35 AM Nick Desaulniers wrote: > > On Thu, Oct 31, 2019 at 10:27 AM Sami Tolvanen wrote: > > > > On Thu, Oct 31, 2019 at 10:18 AM Nick Desaulniers > > wrote: > > > > +#ifdef CONFIG_SHADOW_CALL_STACK > > > > + ldr x18, [x0, #96] > > > > + str xzr, [x0, #96] > > > > > > How come we zero out x0+#96, but not for other offsets? Is this str necessary? > > > > It clears the shadow stack pointer from the sleep state buffer, which > > is not strictly speaking necessary, but leaves one fewer place to find > > it. > > That sounds like a good idea. Consider adding comments or to the > commit message so that the str doesn't get removed accidentally in the > future. Sure, I'll add a comment in the next version. Sami