From: Masahiro Yamada <masahiroy@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Emese Revfy <re.emese@gmail.com>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS
Date: Sun, 29 Mar 2020 20:04:14 +0900 [thread overview]
Message-ID: <CAK7LNARRZ3_z6tjuGJ=PUw5JUtP5AM31wYpr0mnn9yq6VfzQOA@mail.gmail.com> (raw)
In-Reply-To: <202003251906.973AD868@keescook>
On Thu, Mar 26, 2020 at 11:06 AM Kees Cook <keescook@chromium.org> wrote:
>
> On Wed, Mar 25, 2020 at 12:14:32PM +0900, Masahiro Yamada wrote:
> > Add -Wall to catch more warnings for C++ host programs.
> >
> > When I submitted the previous version, the 0-day bot reported
> > -Wc++11-compat warnings for old GCC:
> >
> > HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o
> > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:28:0,
> > from scripts/gcc-plugins/gcc-common.h:15,
> > from scripts/gcc-plugins/latent_entropy_plugin.c:78:
> > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:102:21: warning: C++11 requires a space between string literal and macro [-Wc++11-compat]
> > fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\
> > ^
> > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:170:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat]
> > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \
> > ^
> > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:42:0,
> > from scripts/gcc-plugins/gcc-common.h:15,
> > from scripts/gcc-plugins/latent_entropy_plugin.c:78:
> > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/defaults.h:126:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat]
> > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \
> > ^
> >
> > The source of the warnings is in the plugin headers, so we have no
> > control of it. I just suppressed them by adding -Wno-c++11-compat to
> > scripts/gcc-plugins/Makefile.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> -Kees
Applied to linux-kbuild.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2020-03-29 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 3:14 [PATCH 1/2] kconfig: remove unused variable in qconf.cc Masahiro Yamada
2020-03-25 3:14 ` [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS Masahiro Yamada
2020-03-26 2:06 ` Kees Cook
2020-03-29 11:04 ` Masahiro Yamada [this message]
2020-03-26 2:05 ` [PATCH 1/2] kconfig: remove unused variable in qconf.cc Kees Cook
2020-03-29 11:03 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNARRZ3_z6tjuGJ=PUw5JUtP5AM31wYpr0mnn9yq6VfzQOA@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=re.emese@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).