From: Markus Elfring <Markus.Elfring@web.de>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v4 04/14] irqchip/davinci-aintc: Fix potential resource leaks
Date: Wed, 01 Jul 2020 08:15:19 +0000 [thread overview]
Message-ID: <08cad331-0a17-586c-07a7-6e3843cb61a1@web.de> (raw)
In-Reply-To: <1593569786-11500-5-git-send-email-yangtiezhu@loongson.cn>
…
> +++ b/drivers/irqchip/irq-davinci-aintc.c
> @@ -96,7 +96,7 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
> resource_size(&config->reg));
> if (!davinci_aintc_base) {
> pr_err("%s: unable to ioremap register range\n", __func__);
> - return;
> + goto err_release;
> }
…
Can it help to return any error codes?
Would you like to reconsider the function return type?
Regards,
Markus
next prev parent reply other threads:[~2020-07-01 8:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn>
[not found] ` <1593569786-11500-4-git-send-email-yangtiezhu@loongson.cn>
2020-07-01 7:49 ` [PATCH v4 03/14] irqchip/csky-mpintc: Fix potential resource leaks Markus Elfring
2020-07-01 9:23 ` Tiezhu Yang
[not found] ` <1593569786-11500-5-git-send-email-yangtiezhu@loongson.cn>
2020-07-01 8:15 ` Markus Elfring [this message]
2020-07-01 9:19 ` [PATCH v4 04/14] irqchip/davinci-aintc: " Tiezhu Yang
[not found] ` <1593569786-11500-3-git-send-email-yangtiezhu@loongson.cn>
2020-07-01 8:40 ` [PATCH v4 02/14] irqchip/csky-apb-intc: " Markus Elfring
2020-07-01 9:35 ` Tiezhu Yang
2020-07-01 13:04 ` Markus Elfring
2020-07-02 1:18 ` Tiezhu Yang
2020-07-02 7:19 ` Markus Elfring
2020-07-02 7:19 ` Markus Elfring
2020-07-02 8:05 ` Tiezhu Yang
2020-07-02 11:53 ` Tiezhu Yang
2020-07-02 12:24 ` [v4 " Markus Elfring
2020-07-02 12:35 ` Tiezhu Yang
2020-07-02 15:00 ` [PATCH v4 " Dan Carpenter
[not found] ` <1593569786-11500-12-git-send-email-yangtiezhu@loongson.cn>
2020-07-01 9:14 ` [PATCH v4 11/14] irqchip/omap-intc: Fix potential resource leak Markus Elfring
2020-07-01 9:40 ` Tiezhu Yang
[not found] ` <1593569786-11500-13-git-send-email-yangtiezhu@loongson.cn>
2020-07-01 9:30 ` [PATCH v4 12/14] irqchip/riscv-intc: " Markus Elfring
[not found] ` <1593569786-11500-15-git-send-email-yangtiezhu@loongson.cn>
2020-07-01 9:42 ` [PATCH v4 14/14] irqchip/xilinx-intc: " Markus Elfring
2020-07-01 9:58 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08cad331-0a17-586c-07a7-6e3843cb61a1@web.de \
--to=markus.elfring@web.de \
--cc=jason@lakedaemon.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).