From: Julia Lawall <Julia.Lawall@inria.fr>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Joe Perches" <joe@perches.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
kernel-janitors@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 03/18] [ARM] pata_icside: use semicolons rather than commas to separate statements
Date: Sun, 27 Sep 2020 19:12:13 +0000 [thread overview]
Message-ID: <1601233948-11629-4-git-send-email-Julia.Lawall@inria.fr> (raw)
In-Reply-To: <1601233948-11629-1-git-send-email-Julia.Lawall@inria.fr>
Replace commas with semicolons. What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
drivers/ata/pata_icside.c | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c
index 08543aeb0093..498383cb6e29 100644
--- a/drivers/ata/pata_icside.c
+++ b/drivers/ata/pata_icside.c
@@ -202,14 +202,19 @@ static void pata_icside_set_dmamode(struct ata_port *ap, struct ata_device *adev
* Choose the IOMD cycle timing which ensure that the interface
* satisfies the measured active, recovery and cycle times.
*/
- if (t.active <= 50 && t.recover <= 375 && t.cycle <= 425)
- iomd_type = 'D', cycle = 187;
- else if (t.active <= 125 && t.recover <= 375 && t.cycle <= 500)
- iomd_type = 'C', cycle = 250;
- else if (t.active <= 200 && t.recover <= 550 && t.cycle <= 750)
- iomd_type = 'B', cycle = 437;
- else
- iomd_type = 'A', cycle = 562;
+ if (t.active <= 50 && t.recover <= 375 && t.cycle <= 425) {
+ iomd_type = 'D';
+ cycle = 187;
+ } else if (t.active <= 125 && t.recover <= 375 && t.cycle <= 500) {
+ iomd_type = 'C';
+ cycle = 250;
+ } else if (t.active <= 200 && t.recover <= 550 && t.cycle <= 750) {
+ iomd_type = 'B';
+ cycle = 437;
+ } else {
+ iomd_type = 'A';
+ cycle = 562;
+ }
ata_dev_info(adev, "timings: act %dns rec %dns cyc %dns (%c)\n",
t.active, t.recover, t.cycle, iomd_type);
next prev parent reply other threads:[~2020-09-27 19:12 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 19:12 [PATCH 00/18] use semicolons rather than commas to separate statements Julia Lawall
2020-09-27 19:12 ` [PATCH 01/18] clk: uniphier: " Julia Lawall
2020-10-14 0:44 ` Stephen Boyd
2020-09-27 19:12 ` [PATCH 02/18] ipmi:bt-bmc: " Julia Lawall
2020-09-27 19:12 ` Julia Lawall [this message]
2020-09-28 16:47 ` [PATCH 03/18] [ARM] pata_icside: " Joe Perches
2020-09-28 17:11 ` Julia Lawall
2020-09-28 17:57 ` Joe Perches
2020-09-27 19:12 ` [PATCH 04/18] hwrng: stm32 - " Julia Lawall
2020-10-02 11:55 ` Herbert Xu
2020-09-27 19:12 ` [PATCH 05/18] bcma: " Julia Lawall
2020-10-01 13:24 ` Kalle Valo
2020-09-27 19:12 ` [PATCH 06/18] hwrng: iproc-rng200 - " Julia Lawall
2020-09-28 1:42 ` Florian Fainelli
2020-10-02 11:55 ` Herbert Xu
2020-09-27 19:12 ` [PATCH 07/18] hwrng: mxc-rnga " Julia Lawall
2020-10-02 11:55 ` Herbert Xu
2020-09-27 19:12 ` [PATCH 08/18] agp: " Julia Lawall
2020-09-27 19:12 ` [PATCH 09/18] clk: mvebu: ap80x-cpu: " Julia Lawall
2020-10-14 0:44 ` Stephen Boyd
2020-09-27 19:12 ` [PATCH 10/18] clk: meson: " Julia Lawall
2020-09-28 9:47 ` Jerome Brunet
2020-10-08 1:54 ` Stephen Boyd
2020-10-14 0:44 ` Stephen Boyd
2020-09-27 19:12 ` [PATCH 11/18] clocksource/drivers/mps2-timer: use semicolons rather than commas to separate statemen Julia Lawall
2020-09-27 19:12 ` [PATCH 12/18] ACPI: use semicolons rather than commas to separate statements Julia Lawall
2020-09-27 20:27 ` Christophe JAILLET
2020-09-27 19:12 ` [PATCH 13/18] crypto: " Julia Lawall
2020-10-02 11:56 ` Herbert Xu
2020-09-27 19:12 ` [PATCH 14/18] regmap: debugfs: " Julia Lawall
2020-09-27 19:12 ` [PATCH 15/18] counter: " Julia Lawall
2020-09-28 15:37 ` David Lechner
2020-09-29 15:27 ` Jonathan Cameron
2020-09-27 19:12 ` [PATCH 16/18] clocksource/drivers: " Julia Lawall
2020-09-27 19:12 ` [PATCH 17/18] crypto: atmel-tdes - " Julia Lawall
2020-10-02 11:56 ` Herbert Xu
2020-09-27 19:12 ` [PATCH 18/18] drbd: " Julia Lawall
2020-09-27 20:08 ` [PATCH 00/18] " Joe Perches
[not found] ` <160132172369.55460.9237357219623604216.b4-ty@kernel.org>
2020-09-29 0:45 ` Joe Perches
2020-09-29 11:37 ` Mark Brown
2020-09-29 11:46 ` Julia Lawall
2020-09-29 12:37 ` Mark Brown
2020-09-29 12:44 ` Julia Lawall
2020-09-30 19:33 ` Joe Perches
2020-10-01 11:01 ` Mark Brown
2020-10-03 18:40 ` Joe Perches
2020-10-03 19:15 ` Konstantin Ryabitsev
2020-10-03 19:18 ` Julia Lawall
2020-10-03 19:31 ` Konstantin Ryabitsev
2020-10-03 19:43 ` Joe Perches
2020-10-05 16:52 ` Mark Brown
2020-10-03 19:27 ` Joe Perches
2020-10-03 19:36 ` Joe Perches
2020-09-29 12:20 ` Ard Biesheuvel
2020-09-29 12:36 ` Julia Lawall
2020-09-29 12:41 ` Dan Carpenter
2020-09-29 12:47 ` Julia Lawall
2020-09-29 13:34 ` Joe Perches
2020-09-29 13:42 ` Julia Lawall
2020-09-29 13:42 ` Shuah Khan
2020-10-02 16:47 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1601233948-11629-4-git-send-email-Julia.Lawall@inria.fr \
--to=julia.lawall@inria.fr \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).