From mboxrd@z Thu Jan 1 00:00:00 1970 From: Djalal Harouni Date: Wed, 24 Jun 2015 12:45:33 +0000 Subject: Re: [PATCH] kdbus: Delete an unnecessary check before the function call "kdbus_domain_unref" Message-Id: <20150624124533.GA9939@dztty> List-Id: References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558AA52B.1030809@users.sourceforge.net> In-Reply-To: <558AA52B.1030809@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Daniel Mack , David Herrmann , Greg Kroah-Hartman , LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Wed, Jun 24, 2015 at 02:40:11PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 24 Jun 2015 14:30:17 +0200 > > The kdbus_domain_unref() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > ipc/kdbus/fs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/ipc/kdbus/fs.c b/ipc/kdbus/fs.c > index d01f33b..205a3ad 100644 > --- a/ipc/kdbus/fs.c > +++ b/ipc/kdbus/fs.c > @@ -325,9 +325,7 @@ static void fs_super_kill(struct super_block *sb) > } > > kill_anon_super(sb); > - > - if (domain) > - kdbus_domain_unref(domain); > + kdbus_domain_unref(domain); > } > > static int fs_super_set(struct super_block *sb, void *data) > -- > 2.4.4 > Reviewed-by: Djalal Harouni -- Djalal Harouni http://opendz.org