From: Dan Carpenter <dan.carpenter@oracle.com>
To: Walter Harms <wharms@bfs.de>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH] coresight: cti: Fix error handling in probe
Date: Fri, 12 Jun 2020 17:38:38 +0000 [thread overview]
Message-ID: <20200612173838.GH4282@kadam> (raw)
In-Reply-To: <6c59bdbc15714b089d256ad50aee58cb@bfs.de>
On Fri, Jun 12, 2020 at 02:11:16PM +0000, Walter Harms wrote:
> Hi Dan,
>
> nit picking in cti_pm_release()
>
> IMHO this should be done in 2 steps:
> if (--nr_cti_cpu = 0)
> ->
> --nr_cti_cpu ;
> if ( nr_cti_cpu = 0)
The first way is sort of the more canonical way to write it... By far.
regards,
carpenter
next prev parent reply other threads:[~2020-06-12 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200612121047.GF4282@kadam>
2020-06-12 12:11 ` [PATCH] coresight: cti: Fix error handling in probe Dan Carpenter
2020-06-12 14:11 ` AW: " Walter Harms
2020-06-12 17:38 ` Dan Carpenter [this message]
2020-06-12 17:42 ` Dan Carpenter
2020-06-17 10:53 ` Mike Leach
2020-06-17 14:24 ` Mike Leach
2020-06-17 10:49 ` Mike Leach
2020-06-17 17:15 ` [PATCH v2] " Dan Carpenter
2020-06-29 20:29 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612173838.GH4282@kadam \
--to=dan.carpenter@oracle.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).