From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: eli.billauer@gmail.com, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v1 3/4] char: xillybus: Remove usage of remaining deprecated pci_ API
Date: Mon, 30 Aug 2021 12:48:10 +0300 [thread overview]
Message-ID: <20210830094810.GC12231@kadam> (raw)
In-Reply-To: <19d67ac0208a609aef1e28278b3f2477aa714029.1630083668.git.christophe.jaillet@wanadoo.fr>
On Fri, Aug 27, 2021 at 07:17:47PM +0200, Christophe JAILLET wrote:
> diff --git a/drivers/char/xillybus/xillybus.h b/drivers/char/xillybus/xillybus.h
> index 7c71bdef7ccb..55d47cb13a7b 100644
> --- a/drivers/char/xillybus/xillybus.h
> +++ b/drivers/char/xillybus/xillybus.h
> @@ -87,7 +87,6 @@ struct xilly_channel {
> };
>
> struct xilly_endpoint {
> - struct pci_dev *pdev;
> struct device *dev;
> struct xilly_endpoint_hardware *ephw;
>
> diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
> index 931d0bf4cec6..0ced9ec6977f 100644
> --- a/drivers/char/xillybus/xillybus_core.c
> +++ b/drivers/char/xillybus/xillybus_core.c
> @@ -1783,7 +1783,7 @@ struct xilly_endpoint *xillybus_init_endpoint(struct pci_dev *pdev,
> if (!endpoint)
> return NULL;
>
> - endpoint->pdev = pdev;
> + (void)pdev; // silence a compiler warning, will be removed
Just out of curiousity which compiler warning is this? I don't think
GCC will complain. I think there are other compilers which complain but
I don't know which.
> endpoint->dev = dev;
> endpoint->ephw = ephw;
> endpoint->msg_counter = 0x0b;
regards,
dan carpenter
next prev parent reply other threads:[~2021-08-30 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 17:17 [PATCH v1 0/4] char: xillybus: Remove usage of the deprecated 'pci-dma-compat.h' API Christophe JAILLET
2021-08-27 17:17 ` [PATCH v1 1/4] " Christophe JAILLET
2021-11-03 18:38 ` Christophe JAILLET
2021-08-27 17:17 ` [PATCH v1 2/4] char: xillybus: Remove usage of 'pci_unmap_single()' Christophe JAILLET
2021-08-27 17:17 ` [PATCH v1 3/4] char: xillybus: Remove usage of remaining deprecated pci_ API Christophe JAILLET
2021-08-30 9:48 ` Dan Carpenter [this message]
2021-08-30 17:19 ` Christophe JAILLET
2021-08-27 17:17 ` [PATCH v1 4/4] char: xillybus: Simplify 'xillybus_init_endpoint()' Christophe JAILLET
2021-08-28 15:05 ` [PATCH v1 0/4] char: xillybus: Remove usage of the deprecated 'pci-dma-compat.h' API Eli Billauer
2021-08-28 21:26 ` Arnd Bergmann
2021-08-29 8:23 ` Eli Billauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830094810.GC12231@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=eli.billauer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).