From: David Howells <dhowells@redhat.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: dhowells@redhat.com, Hulk Robot <hulkci@huawei.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] afs: Remove unused variable in afs_req_issue_op()
Date: Wed, 03 Mar 2021 08:23:22 +0000 [thread overview]
Message-ID: <2025008.1614759802@warthog.procyon.org.uk> (raw)
In-Reply-To: <20210303064028.895953-1-weiyongjun1@huawei.com>
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> GCC reports the following warning with W=1:
>
> fs/afs/file.c:291:6: warning:
> unused variable 'ret' [-Wunused-variable]
> 291 | int ret;
> | ^~~
>
> After commit 799fbdf96cd51, this variable is not used in function
> afs_req_issue_op(), so this commit remove it to fix the warning.
>
> Fixes: 799fbdf96cd51 ("afs: Use new fscache read helper API")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I've already fixed that and updated my branch, thanks. linux-next should pick
it up on the next merging.
David
prev parent reply other threads:[~2021-03-04 0:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 6:40 [PATCH -next] afs: Remove unused variable in afs_req_issue_op() Wei Yongjun
2021-03-03 8:23 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025008.1614759802@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).