kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <maz@kernel.org>, Guo Ren <guoren@kernel.org>,
	linux-csky@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Denis Efremov <efremov@linux.com>,
	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: Re: [PATCH v5 03/14] irqchip/csky-mpintc: Fix potential resource leaks
Date: Mon, 06 Jul 2020 06:14:58 +0000	[thread overview]
Message-ID: <3cdb3f12-0862-6985-2236-a724267ead81@web.de> (raw)
In-Reply-To: <1593998365-25910-4-git-send-email-yangtiezhu@loongson.cn>

> … Thus add jump targets for the completion of the desired
> exception handling. By the way, do some coding-style cleanups
> suggested by Markus.

I propose to split these changes.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258#n138

Would you like to support easier back-porting of a fix
besides another bit of possible source code beautification?


…
+++ b/drivers/irqchip/irq-csky-mpintc.c
@@ -241,14 +241,16 @@ csky_mpintc_init(struct device_node *node, struct device_node *parent)
…
 		INTCG_base = ioremap(mfcr("cr<31, 14>"),
-				     INTCL_SIZE*nr_cpu_ids + INTCG_SIZE);
…
+				     INTCL_SIZE * nr_cpu_ids + INTCG_SIZE);

Can any macro (or function) be helpful for such a size computation?

Regards,
Markus

       reply	other threads:[~2020-07-06  6:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1593998365-25910-1-git-send-email-yangtiezhu@loongson.cn>
     [not found] ` <1593998365-25910-4-git-send-email-yangtiezhu@loongson.cn>
2020-07-06  6:14   ` Markus Elfring [this message]
     [not found] ` <1593998365-25910-15-git-send-email-yangtiezhu@loongson.cn>
2020-07-06  7:30   ` [PATCH v5 14/14] irqchip/xilinx-intc: Fix potential resource leak Markus Elfring
     [not found] ` <ab1cd9280c7892a0230945ef5ff0880c@kernel.org>
2020-07-06  7:43   ` [PATCH v5 00/14] irqchip: Fix potential resource leaks Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cdb3f12-0862-6985-2236-a724267ead81@web.de \
    --to=markus.elfring@web.de \
    --cc=efremov@linux.com \
    --cc=garsilva@embeddedor.com \
    --cc=guoren@kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).