From: Markus Elfring <Markus.Elfring@web.de>
To: lumingyindetect@126.com, linux-serial@vger.kernel.org,
kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Jiri Slaby" <jirislaby@kernel.org>
Subject: Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()
Date: Fri, 26 Apr 2024 14:28:43 +0200 [thread overview]
Message-ID: <42c5d1f0-d16a-483b-8bb1-4c5768aa3a8c@web.de> (raw)
In-Reply-To: <20240426114716.1275085-1-lumingyindetect@126.com>
…
> In the lpss8250_probe() function, I added a label named "free_irq_vectors" to release the dynamically allocated memory region pointed to by the variable pdev, and replaced the two return statements mentioned above with goto statements to this label.
* Please improve the word wrapping according to line length preferences
for change descriptions.
* Please choose corresponding imperative wordings.
> Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67
Please add a commit subject for this tag.
> Signed-off-by: LuMingYin <11570291+yin-luming@user.noreply.gitee.com>
I find the author email addresses suspicious according to the Developer's Certificate of Origin.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n398
Would other email addresses be more appropriate for desired patch communication?
Regards,
Markus
next parent reply other threads:[~2024-04-26 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240426114716.1275085-1-lumingyindetect@126.com>
2024-04-26 12:28 ` Markus Elfring [this message]
2024-04-26 13:01 ` Re:Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe() lumingyindetect
2024-04-26 13:51 ` Markus Elfring
2024-04-26 15:07 ` [PATCH] " Christian Heusel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42c5d1f0-d16a-483b-8bb1-4c5768aa3a8c@web.de \
--to=markus.elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lumingyindetect@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).