From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 04 Nov 2015 19:48:51 +0000 Subject: [PATCH] sysfs: Delete an unnecessary check before the function call "kernfs_get" Message-Id: <563A6123.8030506@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org, Greg Kroah-Hartman Cc: kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Wed, 4 Nov 2015 20:44:50 +0100 The kernfs_get() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/sysfs/group.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c index dc1358b..9b34c07 100644 --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c @@ -388,8 +388,7 @@ int __compat_only_sysfs_link_entry_to_kobj(struct kobject *kobj, */ spin_lock(&sysfs_symlink_target_lock); target = target_kobj->sd; - if (target) - kernfs_get(target); + kernfs_get(target); spin_unlock(&sysfs_symlink_target_lock); if (!target) return -ENOENT; -- 2.6.2