From: Jiri Slaby <jirislaby@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tty: moxa: use semi-colons instead of commas
Date: Wed, 25 Aug 2021 14:58:19 +0200 [thread overview]
Message-ID: <67c7047a-93eb-d5fe-514d-6545b5899991@kernel.org> (raw)
In-Reply-To: <20210825072405.GA13013@kili>
On 25. 08. 21, 9:24, Dan Carpenter wrote:
> This code works but it's cleaner to use a semi-colon to end a statement
> instead of a comma.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
I just wonder why:
tty: moxa:
vs
mxser:
with no "tty: "
...
> ---
> drivers/tty/moxa.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> index 776f78de0f82..bf17e90858b8 100644
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
> @@ -2034,10 +2034,10 @@ static int moxa_get_serial_info(struct tty_struct *tty,
> if (!info)
> return -ENODEV;
> mutex_lock(&info->port.mutex);
> - ss->type = info->type,
> - ss->line = info->port.tty->index,
> - ss->flags = info->port.flags,
> - ss->baud_base = 921600,
> + ss->type = info->type;
> + ss->line = info->port.tty->index;
> + ss->flags = info->port.flags;
> + ss->baud_base = 921600;
> ss->close_delay = jiffies_to_msecs(info->port.close_delay) / 10;
> mutex_unlock(&info->port.mutex);
> return 0;
>
--
js
suse labs
next prev parent reply other threads:[~2021-08-25 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 7:24 [PATCH] tty: moxa: use semi-colons instead of commas Dan Carpenter
2021-08-25 12:58 ` Jiri Slaby [this message]
2021-08-25 13:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67c7047a-93eb-d5fe-514d-6545b5899991@kernel.org \
--to=jirislaby@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).