From: Oded Gabbay <oded.gabbay@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Colin King <colin.king@canonical.com>,
Oded Gabbay <ogabbay@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] habanalabs/gaudi: remove redundant assignment to variable err
Date: Sun, 6 Jun 2021 11:32:56 +0300 [thread overview]
Message-ID: <CAFCwf10jJ1Kea8J9xwYgAbxW3P0L2ryPu5xBTN0cN_Zuxu49Pw@mail.gmail.com> (raw)
In-Reply-To: <20210604080503.GJ1955@kadam>
On Fri, Jun 4, 2021 at 11:05 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Thu, Jun 03, 2021 at 02:12:10PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The variable err is being assigned a value that is never read, the
> > assignment is redundant and can be removed. Also remove some empty
> > lines.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/misc/habanalabs/gaudi/gaudi.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
> > index 9e4a6bb3acd1..22f220859b46 100644
> > --- a/drivers/misc/habanalabs/gaudi/gaudi.c
> > +++ b/drivers/misc/habanalabs/gaudi/gaudi.c
> > @@ -7379,9 +7379,6 @@ static int gaudi_hbm_read_interrupts(struct hl_device *hdev, int device,
> > device, ch, hbm_ecc_data->first_addr, type,
> > hbm_ecc_data->sec_cont_cnt, hbm_ecc_data->sec_cnt,
> > hbm_ecc_data->dec_cnt);
> > -
> > - err = 1;
> > -
> > return 0;
> > }
>
> Not related to your patch (which seems fine), but I always feel like
> there should be a rule that function which return a mix of negative
> error codes and either zero or one on success should have to have
> documentation explaining why.
>
> It's impossible to tell from the context here and neither of the callers
> check the return. :P
>
> regards,
> dan carpenter
>
I agree and I will change the function to return only 0 on success, or
standard error value on error.
Anyway, this patch is:
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
prev parent reply other threads:[~2021-06-06 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 13:12 [PATCH] habanalabs/gaudi: remove redundant assignment to variable err Colin King
2021-06-04 8:05 ` Dan Carpenter
2021-06-06 8:32 ` Oded Gabbay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFCwf10jJ1Kea8J9xwYgAbxW3P0L2ryPu5xBTN0cN_Zuxu49Pw@mail.gmail.com \
--to=oded.gabbay@gmail.com \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).