From: Sungwoo Kim <iam@sung-woo.kim>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"Dave (Jing) Tian" <daveti@purdue.edu>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH] Bluetooth: L2CAP: Fix slab-use-after-free in l2cap_send_cmd
Date: Fri, 26 Apr 2024 04:38:24 -0400 [thread overview]
Message-ID: <CAJNyHp+WFONaNbZVK3tPcT=9obEiuE3MvQzJK++HP-ffNdfX0w@mail.gmail.com> (raw)
In-Reply-To: <964b0005-3a9d-499b-91d3-171a3c917b4a@web.de>
On Fri, Apr 26, 2024 at 4:26 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> I prefer that you would put recipient specifications also into the message field “To”
> (besides “Cc”).
Okay.
>
>
> > Hello, could you review a bug and its fix?
>
> I suggest to omit such a question from better change descriptions.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n45
Thank you. I'll thoroughly read this.
>
>
> …
> > To fix this, this patch holds and locks the l2cap channel.
>
> Please choose a corresponding imperative wording.
Okay.
>
>
> You would probably like to improve your patch approach further
> so that provided data will be kept consistent.
I will.
> https://lore.kernel.org/lkml/20240426073142.363876-1-iam@sung-woo.kim/
>
> Regards,
> Markus
>
On Fri, Apr 26, 2024 at 4:26 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> I prefer that you would put recipient specifications also into the message field “To”
> (besides “Cc”).
>
>
> > Hello, could you review a bug and its fix?
>
> I suggest to omit such a question from better change descriptions.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n45
>
>
> …
> > To fix this, this patch holds and locks the l2cap channel.
>
> Please choose a corresponding imperative wording.
>
>
> You would probably like to improve your patch approach further
> so that provided data will be kept consistent.
> https://lore.kernel.org/lkml/20240426073142.363876-1-iam@sung-woo.kim/
>
> Regards,
> Markus
>
next prev parent reply other threads:[~2024-04-26 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240426072006.358802-1-iam@sung-woo.kim>
2024-04-26 8:25 ` [PATCH] Bluetooth: L2CAP: Fix slab-use-after-free in l2cap_send_cmd Markus Elfring
2024-04-26 8:38 ` Sungwoo Kim [this message]
2024-04-26 9:38 ` Dan Carpenter
2024-04-26 9:48 ` Sungwoo Kim
2024-04-26 10:01 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJNyHp+WFONaNbZVK3tPcT=9obEiuE3MvQzJK++HP-ffNdfX0w@mail.gmail.com' \
--to=iam@sung-woo.kim \
--cc=Markus.Elfring@web.de \
--cc=daveti@purdue.edu \
--cc=johan.hedberg@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).