From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: "Roderick Colenbrander" <roderick.colenbrander@sony.com>,
"Jiri Kosina" <jikos@kernel.org>,
"Barnabás Pőcze" <pobrn@protonmail.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] HID: playstation: fix array size comparison (off-by-one)
Date: Wed, 17 Feb 2021 21:04:38 +0100 [thread overview]
Message-ID: <CAO-hwJ+P=jH3ByHdab=qmrOWupnq-fiA0UR8mdHF1pQAuEqbAw@mail.gmail.com> (raw)
In-Reply-To: <20210215163921.84283-1-colin.king@canonical.com>
On Mon, Feb 15, 2021 at 5:39 PM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The comparison of value with the array size ps_gamepad_hat_mapping
> appears to be off-by-one. Fix this by using >= rather than > for the
> size comparison.
>
> Addresses-Coverity: ("Out-of-bounds read")
> Fixes: bc2e15a9a022 ("HID: playstation: initial DualSense USB support.")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Good catch.
Applied to for-5.12/playstation-v2
Cheers,
Benjamin
> drivers/hid/hid-playstation.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
> index 408b651174cf..568a3a067c88 100644
> --- a/drivers/hid/hid-playstation.c
> +++ b/drivers/hid/hid-playstation.c
> @@ -1064,7 +1064,7 @@ static int dualsense_parse_report(struct ps_device *ps_dev, struct hid_report *r
> input_report_abs(ds->gamepad, ABS_RZ, ds_report->rz);
>
> value = ds_report->buttons[0] & DS_BUTTONS0_HAT_SWITCH;
> - if (value > ARRAY_SIZE(ps_gamepad_hat_mapping))
> + if (value >= ARRAY_SIZE(ps_gamepad_hat_mapping))
> value = 8; /* center */
> input_report_abs(ds->gamepad, ABS_HAT0X, ps_gamepad_hat_mapping[value].x);
> input_report_abs(ds->gamepad, ABS_HAT0Y, ps_gamepad_hat_mapping[value].y);
> --
> 2.30.0
>
prev parent reply other threads:[~2021-02-17 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 16:39 [PATCH][next] HID: playstation: fix array size comparison (off-by-one) Colin King
2021-02-17 20:04 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO-hwJ+P=jH3ByHdab=qmrOWupnq-fiA0UR8mdHF1pQAuEqbAw@mail.gmail.com' \
--to=benjamin.tissoires@redhat.com \
--cc=colin.king@canonical.com \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=roderick.colenbrander@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).