From: Markus Elfring <Markus.Elfring@web.de>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: mtu3: disable USB2 LPM
Date: Mon, 29 Jun 2020 07:30:58 +0000 [thread overview]
Message-ID: <af16d716-8bb3-ea1f-e410-b27443f74c31@web.de> (raw)
In-Reply-To: <1593410434-19406-1-git-send-email-chunfeng.yun@mediatek.com>
> A SuperSpeed device shall include the USB 2.0 extension descriptor
> and shall support LPM when operating in USB 2.0 HS mode(see usb3.2
> spec9.6.2.1). But we always don't support it, so disable it by
> default, otherwise device will enter LPM suspend mode when
> connected to Win10 system.
How do you think about a wording variant like the following?
Change description:
A SuperSpeed device shall include the USB 2.0 extension descriptor
and shall support Link Power Management when operating in USB 2.0
High Speed mode. (See also: USB 3.2 specification 9.6.2.1)
But we do not support it generally. Thus disable this functionality
by default.
Otherwise, the device will enter LPM suspend mode when connected
to Win10 system.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
next parent reply other threads:[~2020-06-29 7:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1593410434-19406-1-git-send-email-chunfeng.yun@mediatek.com>
2020-06-29 7:30 ` Markus Elfring [this message]
2020-06-29 8:10 ` [PATCH 1/2] usb: mtu3: disable USB2 LPM Greg Kroah-Hartman
[not found] ` <1593410434-19406-2-git-send-email-chunfeng.yun@mediatek.com>
2020-06-29 8:00 ` [PATCH 2/2] usb: mtu3: fix NULL pointer dereference Markus Elfring
2020-06-29 8:10 ` Greg Kroah-Hartman
2020-06-30 7:28 ` Chunfeng Yun
2020-06-29 16:19 ` Searching for initialisation of variables by function calls before null pointer checks Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af16d716-8bb3-ea1f-e410-b27443f74c31@web.de \
--to=markus.elfring@web.de \
--cc=chunfeng.yun@mediatek.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).