From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Mon, 05 Jan 2015 22:01:55 +0000 Subject: Re: [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the function call "p9_client_clunk" Message-Id: List-Id: References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54A01326.3050306@users.sourceforge.net> <54A06AB9.4020505@users.sourceforge.net> <20150105112206.GC15033@mwanda> <54AB02F3.5020308@users.sourceforge.net> <54AB0844.5090405@users.sourceforge.net> In-Reply-To: <54AB0844.5090405@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Julia Lawall , Dan Carpenter , Eric Van Hensbergen , Latchesar Ionkov , Ron Minnich , v9fs-developer@lists.sourceforge.net, LKML , kernel-janitors@vger.kernel.org > The error response is clear. Are any software developments efforts expected > to clean-up the call stack for unwanted null pointers even more? I found the original patch and looked at the call sites. None of them calls dump_stack. The behavior is thus not the same. With your change, something that was previously treated in an orderly manner will be converted to something that looks like an oops. I assume that the cost of the dump_stack will also be huge. julia