From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: regarding const variables/structures
Date: Wed, 12 Sep 2018 08:51:51 +0200 [thread overview]
Message-ID: <20180912065151.GA13076@kroah.com> (raw)
In-Reply-To: <CAJd9=00U1MAb=Pb0UqNKWEhGL8z9gYnNgG7y=A3xH4cSN-dH9w@mail.gmail.com>
On Wed, Sep 12, 2018 at 11:50:35AM +0530, inventsekar wrote:
> the question is that, how these many const variable issues are left/missed
> by the previous developers?!?!
Because we never realized the benifit of doing so when we created the
code to start with. And then others copied previous code standards and
away we all went.
This developer took the time, wrote the correct tooling, handled
creating the changes and integrating them properly and getting them
merged into hundreds of different kernel subsystems. A non-trivial task
to say the least.
And it has benifited all users of the kernel greatly due to the
increased security it provides. A very nice job.
> per my little knowledge, this task looks
> like a simple one.. many other Kernel Developers should have thought and
> made these changes long before, but i am not able to understand why this
> wasnt done until recently?!?!?
Again, because we never really thought about it. Or if we did, we only
made changes to the 1-2 drivers/subsystems that we controlled. No one
spent the time to look at the whole kernel like Bhumika did, and put in
the hard work to make these changes.
Each individual patch might look "simple", but realize the effort
involved to get all of that work done is not.
Hope this helps,
greg k-h
next prev parent reply other threads:[~2018-09-12 6:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 6:20 regarding const variables/structures inventsekar
2018-09-12 6:51 ` Greg KH [this message]
2018-09-12 7:08 ` Nicholas Mc Guire
2018-09-12 17:10 ` inventsekar
2018-09-12 17:53 ` valdis.kletnieks at vt.edu
2018-09-12 18:23 ` inventsekar
2018-09-13 9:50 ` Tobin C. Harding
2018-09-14 19:49 ` inventsekar
2018-09-17 7:29 ` Shakthi Kannan
2018-09-18 5:46 ` inventsekar
2018-09-17 15:00 ` valdis.kletnieks at vt.edu
2018-09-13 3:42 ` inventsekar
2018-09-13 6:07 ` Nicholas Mc Guire
2018-09-14 19:52 ` inventsekar
2018-09-14 22:09 ` Kenneth Adam Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912065151.GA13076@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).