From: "Irfan Ullah (울라 이르판)" <irfan@dke.khu.ac.kr>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Linux Kernel List <kernelnewbies@kernelnewbies.org>
Subject: Re: Netlink socket returns NULL in vmx.c kernel file
Date: Tue, 5 Nov 2019 12:29:56 +0900 [thread overview]
Message-ID: <CA+mB8Oz22EuQvn4OkMm+cjjdUMA1Y2-i=Vu8YAp-ubX+EhTu9Q@mail.gmail.com> (raw)
In-Reply-To: <694299.1571809092@turing-police>
[-- Attachment #1.1: Type: text/plain, Size: 1017 bytes --]
I have tested code from different aspects. I have searched a lot in two
weeks, but still I am facing the same problem. Can you please check out
what is the problem with my code. Code is in the attached zipped file.
Thank you very much.
On Wed, Oct 23, 2019 at 2:38 PM Valdis Klētnieks <valdis.kletnieks@vt.edu>
wrote:
> On Wed, 23 Oct 2019 11:43:22 +0900, Irfan Ullah said:
>
> > Can you please what's the problem?
>
> To be brutally honest, your code is too unreadable to figure out
> what the problem is.
>
> First off, fix your code formatting to match Linux kernel indenting.
>
> Second, there's a lot of code in your .h file that should be in a .c file.
>
> Third, functions should be static when feasible.
>
--
*Best Regards,*
*Mr. Irfan Ullah*
PhD Candidate
Data and Knowledge Engineering(DKE) Lab
Department of Computer Science and Engineering
Kyung Hee University, South Korea.
+82-010-591-51651 <+82%2010-3877-8867>
sahibzada.iu@gmail.com
sahibzada_irfanullah
[-- Attachment #1.2: Type: text/html, Size: 3003 bytes --]
[-- Attachment #2: Kernel_User_comm.zip --]
[-- Type: application/zip, Size: 7855 bytes --]
[-- Attachment #3: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2019-11-05 3:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 2:43 Netlink socket returns NULL in vmx.c kernel file Irfan Ullah (울라 이르판)
2019-10-23 5:38 ` Valdis Klētnieks
2019-11-05 3:29 ` Irfan Ullah (울라 이르판) [this message]
2019-11-05 7:22 ` Greg KH
2019-11-05 8:59 ` Irfan Ullah (울라 이르판)
2019-11-05 10:43 ` Valdis Klētnieks
2019-11-08 4:54 ` Irfan Ullah (울라 이르판)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+mB8Oz22EuQvn4OkMm+cjjdUMA1Y2-i=Vu8YAp-ubX+EhTu9Q@mail.gmail.com' \
--to=irfan@dke.khu.ac.kr \
--cc=kernelnewbies@kernelnewbies.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).