From: Jeffrey Walton <noloader@gmail.com>
To: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Cc: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
kernelnewbies <kernelnewbies@kernelnewbies.org>
Subject: Re: [PATCH] net/tls: Fix return values for setsockopt
Date: Sat, 30 Nov 2019 08:15:56 -0500 [thread overview]
Message-ID: <CAH8yC8koPyin6--238Q6bN+2vgrpLXegzuxPVzxyvfmJZAJcOw@mail.gmail.com> (raw)
In-Reply-To: <20191130125451.24616-1-vvidic@valentin-vidic.from.hr>
On Sat, Nov 30, 2019 at 7:55 AM Valentin Vidic
<vvidic@valentin-vidic.from.hr> wrote:
>
> ENOTSUPP is not available in userspace:
>
> setsockopt failed, 524, Unknown error 524
>
> Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr>
> ---
> net/tls/tls_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c
> index bdca31ffe6da..5830b8e02a36 100644
> --- a/net/tls/tls_main.c
> +++ b/net/tls/tls_main.c
> @@ -496,7 +496,7 @@ static int do_tls_setsockopt_conf(struct sock *sk, char __user *optval,
> /* check version */
> if (crypto_info->version != TLS_1_2_VERSION &&
> crypto_info->version != TLS_1_3_VERSION) {
> - rc = -ENOTSUPP;
> + rc = -EINVAL;
> goto err_crypto_info;
> }
A quick comment... ENOTSUP is available in <errno.h> [0] if you want
to stay in the "not supported" path.
When searching for "Unknown error 524", I read another kernel module
switched to EOPNOTSUPP [1] According to [2], EOPNOTSUPP is not as bad
because there is a userland message.
Personally, I am mostly indifferent.
[0] http://man7.org/linux/man-pages/man3/errno.3.html
[1] https://lkml.org/lkml/2019/5/16/883
[2] https://patchwork.ozlabs.org/patch/309627/
Jeff
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2019-11-30 13:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 19:36 Kernel TLS Jeffrey Walton
2019-11-29 19:46 ` Alexander Mihalicyn
2019-11-29 19:48 ` Valentin Vidić
2019-11-29 19:57 ` Jeffrey Walton
2019-11-29 20:04 ` Jeffrey Walton
2019-11-30 4:37 ` Jeffrey Walton
2019-11-30 6:16 ` Alexander Mihalicyn
2019-11-30 6:40 ` Valdis Klētnieks
2019-11-30 8:13 ` Bjørn Mork
2019-11-30 9:11 ` Valdis Klētnieks
2019-11-30 10:10 ` Bjørn Mork
2019-11-30 10:34 ` Valdis Klētnieks
2019-11-30 12:54 ` [PATCH] net/tls: Fix return values for setsockopt Valentin Vidic
2019-11-30 13:15 ` Jeffrey Walton [this message]
2019-11-30 13:31 ` Valentin Vidić
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH8yC8koPyin6--238Q6bN+2vgrpLXegzuxPVzxyvfmJZAJcOw@mail.gmail.com \
--to=noloader@gmail.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=valdis.kletnieks@vt.edu \
--cc=vvidic@valentin-vidic.from.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).