From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Greg KH <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"ksummit-discuss@lists.linuxfoundation.org"
<ksummit-discuss@lists.linuxfoundation.org>,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch
Date: Wed, 9 Dec 2020 13:30:26 +0300 [thread overview]
Message-ID: <20201209103026.GF2767@kadam> (raw)
In-Reply-To: <42a599d0f5e4c677648b5e6de8083feb8723a558.camel@perches.com>
On Wed, Dec 09, 2020 at 12:54:30AM -0800, Joe Perches wrote:
> On Wed, 2020-12-09 at 10:58 +0300, Dan Carpenter wrote:
> > On Tue, Dec 08, 2020 at 09:01:49PM -0800, Joe Perches wrote:
> > > On Tue, 2020-12-08 at 16:34 -0800, Kees Cook wrote:
> > >
> > > > If not "Adjusted-by", what about "Tweaked-by", "Helped-by",
> > > > "Corrected-by"?
> > >
> > > Improved-by: / Enhanced-by: / Revisions-by:
> > >
> >
> > I don't think we should give any credit for improvements or enhancements,
> > only for fixes.
>
> Hey Dan.
>
> I do. If a patch isn't comprehensive and a reviewer notices some
> missing coverage or algorithmic performance enhancement, I think that
> should be noted.
>
> > Complaining about style is its own reward.
>
> <chuckle, maybe so. I view it more like coaching...>
>
> I believe I've said multiple times that style changes shouldn't require
> additional commentary added to a patch.
>
> I'm not making any suggestion to comment for style, only logic or defect
> reduction/improvements as described above.
How about we make the standard, "Would this fix be backported to stable?"
>
> > Having to redo a patch is already a huge headache. Normally, I already
> > considered the reviewer's prefered style and decided I didn't like it.
>
> Example please. We both seem to prefer consistent style.
>
For example, if you have a signedness bugs:
ret = frob(unsigned_long_size);
- if (ret < unsigned_long_size)
+ if (ret < 0 || ret < unsigned_long_size)
vs:
+ if (ret < (int)unsigned_long_size)
goto whatever;
To me, whoever fixes the bug gets to choose their prefered style but
maybe some reviewers have strong feelings one way or the other.
> > Then to make me redo the patch in an ugly style and say thank you on
> > top of that??? Forget about it.
>
> Not a thing I've asked for.
>
> > Plus, as a reviewer I hate reviewing patches over and over.
>
> interdiff could be improved.
>
> > I've argued for years that we should have a Fixes-from: tag. The zero
> > day bot is already encouraging people to add Reported-by tags for this
> > and a lot of people do.
>
> It's still a question of what fixes means in any context.
>
> https://www.google.com/search?q=%27fixes-from%3A%27%20carpenter%20site%3Alore.kernel.org
> gives:
> It looks like there aren't many great matches for your search
>
No, I mean people add Reported-by tags for fixes to the original commit
like in commit f026d8ca2904 ("igc: add support to eeprom, registers and
link self-tests").
regards,
dan carpenter
_______________________________________________
Ksummit-discuss mailing list
Ksummit-discuss@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
next prev parent reply other threads:[~2020-12-09 10:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 23:43 [Ksummit-discuss] crediting bug reports and fixes folded into original patch Vlastimil Babka
2020-12-03 4:02 ` Dan Williams
2020-12-03 9:34 ` Leon Romanovsky
2020-12-03 9:36 ` Geert Uytterhoeven
2020-12-03 10:40 ` Leon Romanovsky
2020-12-03 18:30 ` Greg KH
2020-12-03 19:04 ` Leon Romanovsky
2020-12-09 0:34 ` Kees Cook
2020-12-09 5:01 ` Joe Perches
2020-12-09 7:58 ` Dan Carpenter
2020-12-09 8:45 ` Vlastimil Babka
2020-12-09 9:18 ` Geert Uytterhoeven
2020-12-09 8:54 ` Joe Perches
2020-12-09 10:30 ` Dan Carpenter [this message]
2020-12-09 17:45 ` Dan Williams
2020-12-03 10:33 ` Dan Carpenter
2020-12-03 13:41 ` Julia Lawall
2020-12-03 13:58 ` James Bottomley
2020-12-03 16:55 ` Joe Perches
2020-12-03 19:17 ` Konstantin Ryabitsev
2020-12-03 19:24 ` Joe Perches
2020-12-03 21:13 ` James Bottomley
2020-12-03 18:52 ` Matthew Wilcox
2020-12-03 20:04 ` James Bottomley
2020-12-04 4:54 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209103026.GF2767@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).