From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 76F23E81 for ; Mon, 26 Aug 2019 22:06:56 +0000 (UTC) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 17A398A7 for ; Mon, 26 Aug 2019 22:06:56 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id t3so41190447ioj.12 for ; Mon, 26 Aug 2019 15:06:56 -0700 (PDT) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com. [209.85.166.46]) by smtp.gmail.com with ESMTPSA id w5sm16104899iom.33.2019.08.26.15.06.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2019 15:06:53 -0700 (PDT) Received: by mail-io1-f46.google.com with SMTP id 18so41218879ioe.10 for ; Mon, 26 Aug 2019 15:06:53 -0700 (PDT) MIME-Version: 1.0 References: <20190823151843.GH8130@mit.edu> <20190823161947.GA112509@dtor-ws> <20190823164602.GB112509@dtor-ws> In-Reply-To: From: Doug Anderson Date: Mon, 26 Aug 2019 15:06:43 -0700 Message-ID: To: Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Cc: Joel Fernandes , Barret Rhoden , ksummit , Greg Kroah-Hartman , Jonathan Nieder , Tomasz Figa , Han-Wen Nienhuys , Theodore Tso , David Rientjes , Dmitry Torokhov , Dmitry Vyukov Subject: Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, On Mon, Aug 26, 2019 at 2:51 PM Thomas Gleixner wrote: > > On Mon, 26 Aug 2019, Doug Anderson wrote: > > On Mon, Aug 26, 2019 at 10:31 AM Joel Fernandes wrote: > > * At the moment I can't think of any benefit of Change-Id in the > > discardable part of the patch compared to encoding the Change-Id into > > the message ID in a way that it could be extracted. > > What prevents you from munging your change-id into the message id? > > As long as the resulting message ids of your v1..vn series are unique, the > lore link which we want to have inserted automatically works and so does > your change id tracking. > > Most people wont even notice that you do that unless you mess up and break > the uniqueness. Right. This is exactly what I was trying to say in my post, but apparently I failed at it. In case it helps to reiterate my current plan: 1. If some magic happens and folks suddenly embrace Change-Id as part of the patch then I'll be happy because I think adoption will be higher. 2. If, as I expect, Change-Id as part of the patch stays NAKed then I will modify the tools I use to post upstream (currently patman) to encode the Change-Id. My naive proposal would be: Message-Id: ChangeId-YYYY-MMDD-HHMMSS-PatchNum If I try this and it works for me then I will post out and suggest that any other like-minded people encode Change-Id into Message-Id in a similar way. -Doug