From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 80705C9A for ; Fri, 23 Aug 2019 02:58:24 +0000 (UTC) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D3CF067F for ; Fri, 23 Aug 2019 02:58:23 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id x3so7453921lji.5 for ; Thu, 22 Aug 2019 19:58:23 -0700 (PDT) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id f17sm360951lfa.67.2019.08.22.19.58.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2019 19:58:20 -0700 (PDT) Received: by mail-lj1-f174.google.com with SMTP id h15so7426060ljg.10 for ; Thu, 22 Aug 2019 19:58:19 -0700 (PDT) MIME-Version: 1.0 References: <20190823013619.GA8130@mit.edu> In-Reply-To: <20190823013619.GA8130@mit.edu> From: Linus Torvalds Date: Thu, 22 Aug 2019 19:58:03 -0700 Message-ID: To: "Theodore Y. Ts'o" Content-Type: text/plain; charset="UTF-8" Cc: Joel Fernandes , Barret Rhoden , ksummit , Greg Kroah-Hartman , Jonathan Nieder , Tomasz Figa , Han-Wen Nienhuys , Theodore Tso , David Rientjes , Dmitry Torokhov , Dmitry Vyukov Subject: Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Aug 22, 2019 at 6:36 PM Theodore Y. Ts'o wrote: > > Surely it's obvious that: > > Link: https://linux-review.googlesource.com/c/1158 > > is more useful than: > > Change-Id: I3268f9036512c4378cde1da37e0612b43ed4d384 Yes, I think that just using the link when you have a public-facing gerrit database is perfectly fine already today, and people could start using it. Might that link some day die? Sure. That's fundamental to any external link. I don't think it's all that productive to then argue whose links are more likely to die before some other link, unless it looks like some project is actively trying to game the system and has a pattern of having links that are active only for a short while after the commit has gone public. And I don't see much point to doing that. So yes, I'd *much* rather see that "Link" line than try to make a "Change-ID" line be a thing. Of course, looking at that particular link, my initial reaction is "people are bad spellers". The word 'amend' has a single 'm' ;) And it _is_ important that the link in question is stable, of course. Some systems have problems with that. Is that "c/1158" actually a stable long-lived name that will stay around as the thing is modified? I don't know how that system works. Linus