From: Guenter Roeck <linux@roeck-us.net>
To: Shuah Khan <skhan@linuxfoundation.org>,
ksummit <ksummit-discuss@lists.linuxfoundation.org>,
ksummit@lists.linux.dev
Subject: Re: [TECH TOPIC] Driver probe fails and register succeeds
Date: Thu, 23 Jun 2022 16:24:09 -0700 [thread overview]
Message-ID: <febcf31f-074f-56f7-7cb7-7824111e1453@roeck-us.net> (raw)
In-Reply-To: <d39ab7f8-db79-2f0d-9d2c-ecce42505b10@linuxfoundation.org>
On 6/23/22 16:05, Shuah Khan wrote:
> I have been debugging a driver probe failure and noticed that driver gets
> registered even when driver probe fails. This is not a new behavior. The
> code in question is the same since 2005.
>
> dmesg will say that a driver probe failed with error code and then the very
> next message from interface core that says driver is registered successfully.
> It will create sysfs interfaces.
>
> The probe failure is propagated from the drive probe routine all the way up to
> __driver_attach(). __driver_attach() ignores the error and and returns success.
>
> __device_driver_lock(dev, dev->parent);
> driver_probe_device(drv, dev);
> __device_driver_unlock(dev, dev->parent);
>
> return 0;
>
> Interface driver register goes on to create sysfs entries as if driver probe
> worked. It handles errors from driver_register() and unwinds the register
> properly, however in this case it doesn't know about the failure.
>
> At this point the driver is defunct with sysfs interfaces. User has to run
> rmmod to get rid of the defunct driver.
>
> Simply returning the error from __driver_attach() didn't work as expected.
> I figured it would fail since not all interface drivers can handle errors
> from driver probe routines.
>
> I propose that we discuss the scenario to find possible solutions to avoid
> defunct drivers.
>
Doesn't this confuse device probe from loading the driver ? If multiple devices
are instantiated using a single driver, I would not want the driver to unload
because one of the devices it supports failed to probe.
Guenter
next prev parent reply other threads:[~2022-06-23 23:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 23:05 [TECH TOPIC] Driver probe fails and register succeeds Shuah Khan
2022-06-23 23:13 ` Laurent Pinchart
2022-06-23 23:28 ` Shuah Khan
2022-06-23 23:30 ` Laurent Pinchart
2022-06-23 23:38 ` Shuah Khan
2022-06-23 23:57 ` Dan Williams
2022-06-24 1:00 ` Dmitry Torokhov
2022-06-24 6:33 ` Greg KH
2022-06-23 23:24 ` Guenter Roeck [this message]
2022-06-24 6:31 ` Greg KH
2022-06-24 15:55 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=febcf31f-074f-56f7-7cb7-7824111e1453@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=ksummit@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).