From: Tom Lendacky <thomas.lendacky@amd.com>
To: Sean Christopherson <seanjc@google.com>,
Vipin Sharma <vipinsh@google.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
brijesh.singh@amd.com, tj@kernel.org, rdunlap@infradead.org,
jon.grimm@amd.com, eric.vantassell@amd.com, pbonzini@redhat.com,
hannes@cmpxchg.org, frankja@linux.ibm.com,
borntraeger@de.ibm.com, corbet@lwn.net, vkuznets@redhat.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, gingell@google.com, rientjes@google.com,
dionnaglaze@google.com, kvm@vger.kernel.org, x86@kernel.org,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Patch v3 1/2] cgroup: sev: Add misc cgroup controller
Date: Fri, 12 Mar 2021 15:18:28 -0600 [thread overview]
Message-ID: <04f58780-5392-63ed-589b-259de695e4c3@amd.com> (raw)
In-Reply-To: <YEvUTatAjIoP7dPD@google.com>
On 3/12/21 2:51 PM, Sean Christopherson wrote:
> On Fri, Mar 12, 2021, Vipin Sharma wrote:
>> On Thu, Mar 11, 2021 at 07:59:03PM +0100, Michal Koutný wrote:
>>>> +#ifndef CONFIG_KVM_AMD_SEV
>>>> +/*
>>>> + * When this config is not defined, SEV feature is not supported and APIs in
>>>> + * this file are not used but this file still gets compiled into the KVM AMD
>>>> + * module.
>>>> + *
>>>> + * We will not have MISC_CG_RES_SEV and MISC_CG_RES_SEV_ES entries in the enum
>>>> + * misc_res_type {} defined in linux/misc_cgroup.h.
>>> BTW, was there any progress on conditioning sev.c build on
>>> CONFIG_KVM_AMD_SEV? (So that the defines workaround isn't needeed.)
>>
>> Tom, Brijesh,
>> Is this something you guys thought about or have some plans to do in the
>> future? Basically to not include sev.c in compilation if
>> CONFIG_KVM_AMD_SEV is disabled.
>
> It's crossed my mind, but the number of stubs needed made me back off. I'm
> certainly not opposed to the idea, it's just not a trivial change.
Right, I looked at it when I was doing the SEV-ES work and came to the
same conclusion.
Thanks,
Tom
>
next prev parent reply other threads:[~2021-03-12 21:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 23:19 [Patch v3 0/2] cgroup: New misc cgroup controller Vipin Sharma
2021-03-04 23:19 ` [Patch v3 1/2] cgroup: sev: Add " Vipin Sharma
2021-03-11 18:59 ` Michal Koutný
2021-03-12 19:07 ` Vipin Sharma
2021-03-15 18:34 ` Michal Koutný
2021-03-12 19:48 ` Vipin Sharma
2021-03-12 20:51 ` Sean Christopherson
2021-03-12 21:18 ` Tom Lendacky [this message]
2021-03-19 21:28 ` Jacob Pan
2021-03-22 18:54 ` Vipin Sharma
2021-03-24 16:17 ` Jacob Pan
2021-03-24 22:09 ` Vipin Sharma
2021-03-04 23:19 ` [Patch v3 2/2] cgroup: sev: Miscellaneous cgroup documentation Vipin Sharma
2021-03-07 12:48 ` [Patch v3 0/2] cgroup: New misc cgroup controller Tejun Heo
2021-03-11 18:58 ` Michal Koutný
2021-03-11 19:39 ` Tejun Heo
2021-03-12 17:49 ` Vipin Sharma
2021-03-15 19:10 ` Michal Koutný
2021-03-22 18:24 ` Vipin Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04f58780-5392-63ed-589b-259de695e4c3@amd.com \
--to=thomas.lendacky@amd.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dionnaglaze@google.com \
--cc=eric.vantassell@amd.com \
--cc=frankja@linux.ibm.com \
--cc=gingell@google.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=jon.grimm@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=pbonzini@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vipinsh@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).