From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, kvm@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>,
x86@kernel.org, Lenny Szubowicz <lszubowi@redhat.com>,
Mohamed Aboubakr <mabouba@amazon.com>,
Xiaoyi Chen <cxiaoyi@amazon.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] x86/kvm: Refactor KVM PV features teardown and fix restore from hibernation
Date: Mon, 3 May 2021 17:26:00 +0200 [thread overview]
Message-ID: <1134cd5c-29f4-c149-4380-1f6bff193398@redhat.com> (raw)
In-Reply-To: <20210414123544.1060604-1-vkuznets@redhat.com>
On 14/04/21 14:35, Vitaly Kuznetsov wrote:
> This series is a successor of Lenny's "[PATCH] x86/kvmclock: Stop kvmclocks
> for hibernate restore". While reviewing his patch I realized that PV
> features teardown we have is a bit messy: it is scattered across kvm.c
> and kvmclock.c and not all features are being shutdown an all paths.
> This series unifies all teardown paths in kvm.c and makes sure all
> features are disabled when needed.
>
> Vitaly Kuznetsov (5):
> x86/kvm: Fix pr_info() for async PF setup/teardown
> x86/kvm: Teardown PV features on boot CPU as well
> x86/kvm: Disable kvmclock on all CPUs on shutdown
> x86/kvm: Disable all PV features on crash
> x86/kvm: Unify kvm_pv_guest_cpu_reboot() with kvm_guest_cpu_offline()
>
> arch/x86/include/asm/kvm_para.h | 10 +--
> arch/x86/kernel/kvm.c | 113 +++++++++++++++++++++-----------
> arch/x86/kernel/kvmclock.c | 26 +-------
> 3 files changed, 78 insertions(+), 71 deletions(-)
>
Queuing this patch, thanks.
If the Amazon folks want to provide their Tested-by (since they looked
at it before and tested Lenny's first attempt at using syscore_ops),
they're still in time!
Paolo
next prev parent reply other threads:[~2021-05-03 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 12:35 [PATCH 0/5] x86/kvm: Refactor KVM PV features teardown and fix restore from hibernation Vitaly Kuznetsov
2021-04-14 12:35 ` [PATCH 1/5] x86/kvm: Fix pr_info() for async PF setup/teardown Vitaly Kuznetsov
2021-04-14 12:35 ` [PATCH 2/5] x86/kvm: Teardown PV features on boot CPU as well Vitaly Kuznetsov
2021-04-14 12:35 ` [PATCH 3/5] x86/kvm: Disable kvmclock on all CPUs on shutdown Vitaly Kuznetsov
2021-04-14 12:35 ` [PATCH 4/5] x86/kvm: Disable all PV features on crash Vitaly Kuznetsov
2021-04-14 12:35 ` [PATCH 5/5] x86/kvm: Unify kvm_pv_guest_cpu_reboot() with kvm_guest_cpu_offline() Vitaly Kuznetsov
2021-05-03 15:26 ` Paolo Bonzini [this message]
2021-05-05 17:27 ` [PATCH 0/5] x86/kvm: Refactor KVM PV features teardown and fix restore from hibernation Aboubakr, Mohamed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134cd5c-29f4-c149-4380-1f6bff193398@redhat.com \
--to=pbonzini@redhat.com \
--cc=cxiaoyi@amazon.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lszubowi@redhat.com \
--cc=mabouba@amazon.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).