From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH kvm-unit-test 5/6] Add a simple kvmclock driver
Date: Sun, 29 Aug 2010 23:25:54 -0400 (EDT)
Message-ID: <1424287319.826241283138754729.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
References: <206398826.826221283138725330.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: mtosatti@redhat.com, avi@redhat.com, kvm@vger.kernel.org
To: Glauber Costa <glommer@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3-phx2.redhat.com ([209.132.183.24]:40623 "EHLO
	mx01.colomx.prod.int.phx2.redhat.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753959Ab0H3DZz (ORCPT
	<rfc822;kvm@vger.kernel.org>); Sun, 29 Aug 2010 23:25:55 -0400
In-Reply-To: <206398826.826221283138725330.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


----- "Glauber Costa" <glommer@redhat.com> wrote:

> On Fri, Aug 27, 2010 at 01:49:45PM +0800, Jason Wang wrote:
> > +#define unlikely(x)	__builtin_expect(!!(x), 0)
> > +
> > +struct pvclock_vcpu_time_info hv_clock[MAX_CPU];
> this structure have to be 4-byte aligned. Let the compiler
> help you guaranteeing it here.
> 
> > +#define MAX_CPU 4
> > +
> Any particular reason for the number 4? I'd like
> to see these tests running in really big boxes,
> where things get really interesting.

Just because the max cpu num was limited by smp initialization code. I
would change it to 64.